Open Bug 2086008 Opened 23 days ago Updated 1 day ago

Check the window title after navigating in browser_taskbarTabs_title.js

Categories

(Firefox :: Web Apps, defect, P3)

defect

Tracking

()

ASSIGNED

People

(Reporter: mferreiro, Assigned: cqr, Mentored, NeedInfo)

References

Details

(Keywords: good-first-bug, Whiteboard: [FIDE-engagement])

Attachments

(1 external file)

Filing as a good first bug to learn workflows.

In browser/components/taskbartabs/test/browser/browser_taskbarTabs_title.js, the tasks test_defaultCase, test_container, test_profile and test_profileAndContainer each run their assertions twice: once when the Taskbar Tab window opens, and again after phaseAfterContentTitle(win) has navigated the tab. The second round is meant to check that the window title is still right once the page title changes, but it reuses the title string read before navigating:

const title = win.document.title;
assertHasTaskbarTabName(aPrivate, title);

await phaseAfterContentTitle(win);
assertHasTaskbarTabName(aPrivate, title); // still the old title

title is a copy of the window title at the time it was read, so the checks after navigating never look at the current title and cannot fail.

Link to the code:
https://searchfox.org/firefox-main/source/browser/components/taskbartabs/test/browser/browser_taskbarTabs_title.js

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

The severity field is not set for this bug.
:iholmes, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(iholmes)
Severity: -- → S3
Assignee: nobody → cquammerhoden
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: