Closed Bug 2086069 Opened 19 days ago Closed 18 days ago

Vendor application-services with the credit card CVV update fix and clear CVVs on desktop with an empty string

Categories

(Toolkit :: Form Autofill, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [fxcm-backlog])

Attachments

(2 external files)

Bug 2085717 changed the application-services autofill store so that update_credit_card keeps the stored CVV when cc_cvv is null, and clears it only when it is an empty string. Scrubbing encrypted data now also clears the CVV.

Desktop needs to:

  1. Vendor an application-services revision that includes that change.
  2. Pass an empty string instead of null from jsRecordToUpdatableCreditCardFields in RustAutofillCreditCardStorage.sys.mjs when a record has no cc-csc. Otherwise clearing a security code on desktop silently keeps the old one.

Vendor application-services 53354393f, which merges #7687 (bug 2085717):
update_credit_card keeps the stored CVV when cc_cvv is null and clears it when
it is empty, and scrubbing encrypted data clears the CVV along with the number.

The revision also carries the upstream changes since eba864f9: Remote Settings
client errors include the server's error details (bug 1941569), ads-client
telemetry strings are cut to Glean's limit (bug 2047640), and
viaduct-backend-rust moves to reqwest 0.13.5 (bug 2084735).

This also includes the file changes from ./mach uniffi generate.

The Rust store now keeps the stored CVV when an update passes null, so
clearing a security code on desktop has to pass an empty string.

The update doorhanger test pins existing behaviour: a form submitted with an
empty security code field keeps the stored one.

Depends on D337094

Whiteboard: [fxcm-backlog]
Pushed by dlee@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5a39ae6d8f22 https://hg.mozilla.org/integration/autoland/rev/9b24ca28bd1e P1. Vendor application-services 53354393 r=theidkamp https://github.com/mozilla-firefox/firefox/commit/fd3ebb9d4190 https://hg.mozilla.org/integration/autoland/rev/e32baf860048 P2. Clear a credit card's CVV by passing an empty string to the Rust store r=credential-management-reviewers,theidkamp
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: