Closed Bug 2086153 Opened 20 days ago Closed 18 days ago

[customizable menu] Allow the new menu ride the trains

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(4 external files)

Based on the QA validation results the new menu looks and functions exactly like the legacy one so we can let it ride the trains.

The cleanup of the legacy menu will happen separately, later.

This is the same main menu built on a different API.
Menu section or menu items customization support will be added later.
Cleaning up the legacy menu code will happen separately, later.

Attachment #9668935 - Attachment description: Bug 2086153 - Let the customizable menu ride the trains r=#android-reviewers → Bug 2086153 - part 1 - Let the customizable menu ride the trains r=#android-reviewers

A focused item in a LazyColumn sticky header could keep Compose busy indefinitely.
Opening the menu focuses its first enabled header item so UI tests could have
timed out.

Attachment #9668935 - Attachment description: Bug 2086153 - part 1 - Let the customizable menu ride the trains r=#android-reviewers → Bug 2086153 - part 2 - Let the customizable menu ride the trains r=#android-reviewers
Attachment #9669022 - Attachment description: Bug 2086153 - part 2 - Adapt legacy UI tests r=#android-reviewers → Bug 2086153 - part 3 - Adapt legacy UI tests r=#android-reviewers
Attachment #9669023 - Attachment description: Bug 2086153 - part 3 - Adapt efficiency UI tests r=#android-reviewers → Bug 2086153 - part 4 - Adapt efficiency UI tests r=#android-reviewers
Whiteboard: [fxdroid][android-core]
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d487cb7d52f0 https://hg.mozilla.org/integration/autoland/rev/c2d7ad4d14ca part 1 - Keep the menu header out of its scrolling list r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/033d5bca23e3 https://hg.mozilla.org/integration/autoland/rev/ecaa24b3fa0c part 2 - Let the customizable menu ride the trains r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/4be23b2d7bf7 https://hg.mozilla.org/integration/autoland/rev/a26a2f1e8dfb part 3 - Adapt legacy UI tests r=android-reviewers,mobiletest-reviewers,giorga,aaronmt https://github.com/mozilla-firefox/firefox/commit/e3b8b34c6731 https://hg.mozilla.org/integration/autoland/rev/e9e4b846e2b4 part 4 - Adapt efficiency UI tests r=android-reviewers,mobiletest-reviewers,jajohnson,giorga
See Also: → 2092186
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: