Avoid needless flex item reflows and intrinsic-size invalidation caused by abspos and fixed-height descendants
Categories
(Core :: Layout, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: mayankleoboy1, Assigned: mayankleoboy1)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(3 external files)
| Assignee | ||
Comment 1•20 days ago
•
|
||
AbsoluteContainingBlock handles container-size dependencies after the containing block size is final, so these frames do not need to force additional flex item reflows.
Updated•20 days ago
|
| Assignee | ||
Comment 2•20 days ago
•
|
||
Skip child dependency flags when a fixed block-size supplies the percentage basis independently of the parent, retaining the existing checks for special sizing cases and flexed block sizes.
| Assignee | ||
Comment 3•20 days ago
•
|
||
Use IntrinsicDirty::None for placeholder-only child-list changes. Include the shared mochitest comparing incremental and reconstructed layout for nested flex items with abspos and fixed-height descendants; it also logs reflow counts.
| Assignee | ||
Comment 4•20 days ago
|
||
combined perf improvement for all the three patches : https://perf.compare/compare-results?baseRev=8f3e97bd0c25b734a88b43563db372bff9d04d67&baseRepo=try&newRev=50ba91766d93bee93a14aa5c4ddb587ffdf14835&newRepo=try&framework=1&framework=13&sort=median-diff%7Cdesc&initialized=1 (~2.5% on NewsSite Next/Nuxt)
| Assignee | ||
Comment 5•20 days ago
|
||
respond to the review comments on the three patches and update the patch wherever needed. Dont put any comment on bugzilla.
Updated•20 days ago
|
| Assignee | ||
Comment 6•19 days ago
|
||
Emilio, do you have a specific preference for https://phabricator.services.mozilla.com/D337174#11712980 /https://phabricator.services.mozilla.com/D337174#11710573 on the approach for your whack-a-mole comment?
| Assignee | ||
Comment 8•19 days ago
|
||
respond to the review comments on the three patches and update the patch wherever needed. Dont put any comment on bugzilla.
Updated•19 days ago
|
Updated•19 days ago
|
Updated•19 days ago
|
Updated•19 days ago
|
| Assignee | ||
Comment 9•18 days ago
|
||
Address the review comments on https://phabricator.services.mozilla.com/D337174
Updated•18 days ago
|
Updated•18 days ago
|
Comment 10•4 days ago
|
||
Updated•4 days ago
|
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/65103 for changes under testing/web-platform/tests
Comment 12•4 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a7c59483abf3
https://hg.mozilla.org/mozilla-central/rev/aa1fcb020504
https://hg.mozilla.org/mozilla-central/rev/3b9dcbc863d7
Upstream PR merged by moz-wptsync-bot
Comment 14•7 hours ago
|
||
Perfherder has detected a browsertime performance change from push 3b9dcbc863d715b37d89dd20c4c976434809c387.
No action is required from the author; this comment is provided for informational purposes only.
| Improvements | Test | Platform | Options | Absolute values [old vs new] | Performance Profiles |
|---|---|---|---|---|---|
| 3% | speedometer3 NewsSite-Nuxt/total (doc) | linux2404-64-nightlyasrelease | fission webrender | 138.08 ms -> 133.60 ms | |
| 3% | speedometer3 NewsSite-Next/total (doc) | linux2404-64-nightlyasrelease | fission webrender | 172.62 ms -> 167.33 ms | |
| 3% | speedometer3 NewsSite-Nuxt/total (doc) | windows11-64-24h2-shippable | fission webrender | 84.52 ms -> 82.03 ms | Before/After |
| 3% | speedometer3 NewsSite-Next/total (doc) | windows11-64-24h2-nightlyasrelease | fission webrender | 109.15 ms -> 106.06 ms | Before/After |
| 3% | speedometer3 NewsSite-Nuxt/total (doc) | linux2404-64-shippable | fission webrender | 143.82 ms -> 139.75 ms | |
| ... | ... | ... | ... | ... | ... |
| 1% | speedometer3 total (doc) | linux2404-64-shippable | fission webrender | 1,498.00 ms -> 1,488.74 ms |
Need Help or Information?
If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
Description
•