Closed Bug 2086545 Opened 23 days ago Closed 9 days ago

[customizable-menu] Whenever the navigation menu items section is moved break the toolbar position dependency

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

By default the navigation menu items section is shown at the same position in the menu as the toolbar position - top/bottom.
In the "Customize menu" screen this section will initially be shown following the same logic
But as soon as the user changes is position in the menu (by moving it or having other section move it) we should take it as an indication that the navigation menu items section should not anymore follow the toolbar position.
Reverting the menu structure to default should restore this section positioning depending on the toolbar position.

The navigation section is shown on the toolbar's side of the browser menu,
also for a customized menu if it was saved first or last. This moved it
back if the user put it on the other side of the menu.
Save whether the user moved it and only then keep it where it was saved,
until the menu is restored to its default structure, also if it is then on
the toolbar's side. Otherwise always show it on the toolbar's side.

Assignee: nobody → petru
Status: NEW → ASSIGNED
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b1091d5ac128 https://hg.mozilla.org/integration/autoland/rev/8160e4781018 Stop the navigation section of the browser menu following the toolbar once the user moved it r=android-reviewers,giorga
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Regressions: 2094206
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: