Closed Bug 2086608 Opened 21 days ago Closed 20 days ago

`mach try auto` pushes run autoland-cadence perf tasks on every 10th try push

Categories

(Firefox Build System :: Task Configuration, defect)

defect

Tracking

(firefox-esr153 unaffected, firefox159 unaffected, firefox160 unaffected, firefox161 fixed)

RESOLVED FIXED
161 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox159 --- unaffected
firefox160 --- unaffected
firefox161 --- fixed

People

(Reporter: jcristau, Assigned: jcristau)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 external files)

On try pushes made with mach try auto, perf tasks optimized with perf-cadence-expanded (e.g. the *-nightlyasrelease/opt-browsertime-benchmark-firefox-speedometer3 tasks) are scheduled whenever the try pushlog_id is a multiple of 10, regardless of what the push changes.

Example: https://treeherder.mozilla.org/jobs?repo=try&revision=25063069d43aa08df4ba8d1d1d390c143bbcd3c6 only touched .taskcluster.yml and try_task_config.json, but ran the speedometer3 browsertime tasks on Linux, macOS and Windows because its pushlog_id was 1573990.

The tryselect overrides in taskcluster/gecko_taskgraph/optimize/__init__.py replace skip-unless-backstop and skip-unless-expanded with bugbug-reduced, since backstop and expanded pushes only make sense on autoland. Bug 2055854 moved perf tasks to the perf-cadence-backstop / perf-cadence-expanded pass-through aliases, and overrides are matched by the strategy name a task lists, so the try override no longer applies to them and the autoland push-interval logic (SkipUnlessPushInterval) runs on try instead.

Fix: add perf-cadence-backstop and perf-cadence-expanded to the tryselect overrides.

Perf tasks reference the perf-cadence-* aliases rather than the
underlying strategies, so the tryselect overrides keyed on
skip-unless-backstop and skip-unless-expanded no longer matched them.

Assignee: nobody → jcristau
Status: NEW → ASSIGNED
Pushed by jcristau@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/61ec5138984e https://hg.mozilla.org/integration/autoland/rev/3a5693dc9660 Apply the try overrides for backstop and expanded pushes to the perf-cadence aliases. r=taskgraph-reviewers,bhearsum DONTBUILD
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2e9d30e9a2d6 https://hg.mozilla.org/integration/autoland/rev/c1988059b7f9 Revert "Bug 2086608 - Apply the try overrides for backstop and expanded pushes to the perf-cadence aliases. r=taskgraph-reviewers,bhearsum DONTBUILD" for causing firefox-ci failures on test_mach_try_auto.py.

Revert for causing firefox-ci failures on test_mach_try_auto.py.

Flags: needinfo?(jcristau)

The real bugbug knows about these tasks, but they are missing from the
stale known_tasks list in the test data, so they would be scheduled by
mach try auto once perf tasks are optimized with bugbug on try.

The tests set up a non-backstop push, which hid perf tasks being
scheduled on try on every 10th push. Since bug 1660506 the backstop is
no longer computed during optimization, so the pushlog mock it needed is
unused. The files changed mock never matched the json-pushchangedfiles
endpoint, so remove it too.

Pushed by jcristau@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f83a1d9ff5a5 https://hg.mozilla.org/integration/autoland/rev/f74ced8be067 Add perf tasks to the mocked bugbug known tasks. r=taskgraph-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/dfd8e43de80c https://hg.mozilla.org/integration/autoland/rev/2463f5c40ec5 Apply the try overrides for backstop and expanded pushes to the perf-cadence aliases. r=taskgraph-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/3e918b26bb10 https://hg.mozilla.org/integration/autoland/rev/14c0272a40aa Test mach try auto on a push that would be expanded on autoland. r=taskgraph-reviewers,bhearsum
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: