`mach try auto` pushes run autoland-cadence perf tasks on every 10th try push
Categories
(Firefox Build System :: Task Configuration, defect)
Tracking
(firefox-esr153 unaffected, firefox159 unaffected, firefox160 unaffected, firefox161 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr153 | --- | unaffected |
| firefox159 | --- | unaffected |
| firefox160 | --- | unaffected |
| firefox161 | --- | fixed |
People
(Reporter: jcristau, Assigned: jcristau)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 external files)
On try pushes made with mach try auto, perf tasks optimized with perf-cadence-expanded (e.g. the *-nightlyasrelease/opt-browsertime-benchmark-firefox-speedometer3 tasks) are scheduled whenever the try pushlog_id is a multiple of 10, regardless of what the push changes.
Example: https://treeherder.mozilla.org/jobs?repo=try&revision=25063069d43aa08df4ba8d1d1d390c143bbcd3c6 only touched .taskcluster.yml and try_task_config.json, but ran the speedometer3 browsertime tasks on Linux, macOS and Windows because its pushlog_id was 1573990.
The tryselect overrides in taskcluster/gecko_taskgraph/optimize/__init__.py replace skip-unless-backstop and skip-unless-expanded with bugbug-reduced, since backstop and expanded pushes only make sense on autoland. Bug 2055854 moved perf tasks to the perf-cadence-backstop / perf-cadence-expanded pass-through aliases, and overrides are matched by the strategy name a task lists, so the try override no longer applies to them and the autoland push-interval logic (SkipUnlessPushInterval) runs on try instead.
Fix: add perf-cadence-backstop and perf-cadence-expanded to the tryselect overrides.
| Assignee | ||
Comment 1•21 days ago
|
||
Perf tasks reference the perf-cadence-* aliases rather than the
underlying strategies, so the tryselect overrides keyed on
skip-unless-backstop and skip-unless-expanded no longer matched them.
Updated•21 days ago
|
Comment 4•21 days ago
|
||
Revert for causing firefox-ci failures on test_mach_try_auto.py.
| Assignee | ||
Comment 5•21 days ago
|
||
The real bugbug knows about these tasks, but they are missing from the
stale known_tasks list in the test data, so they would be scheduled by
mach try auto once perf tasks are optimized with bugbug on try.
| Assignee | ||
Comment 6•21 days ago
|
||
The tests set up a non-backstop push, which hid perf tasks being
scheduled on try on every 10th push. Since bug 1660506 the backstop is
no longer computed during optimization, so the pushlog mock it needed is
unused. The files changed mock never matched the json-pushchangedfiles
endpoint, so remove it too.
Comment 8•20 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f74ced8be067
https://hg.mozilla.org/mozilla-central/rev/2463f5c40ec5
https://hg.mozilla.org/mozilla-central/rev/14c0272a40aa
Updated•16 days ago
|
Description
•