Closed Bug 2086787 Opened 24 days ago Closed 8 days ago

Correctly handle collapsing margins in non-auto line-clamp containers

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Points:
2

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox161 --- wontfix
firefox162 --- fixed

People

(Reporter: salipov, Assigned: salipov)

References

Details

(Whiteboard: css-line-clamp, [wptsync upstream])

Attachments

(5 external files)

See tests line-clamp-023..025.html. If we make numbered line-clamp take 2 reflows too, then this should be trivially fixable.

Assignee: nobody → salipov
Status: NEW → ASSIGNED
Points: --- → 2
Whiteboard: css-line-clamp
Attachment #9681968 - Attachment description: Bug 2086787: Rename and update comments for flags that determine whether line-clamp should apply. r=#layout → Bug 2086787 Part 1: Rename and update comments for flags that determine whether line-clamp should apply. r=#layout
Attachment #9681969 - Attachment description: Bug 2086787: Move IsBEndMarginRoot() out of LineClampLineIterator, and declare its getters as const. r=#layout → Bug 2086787 Part 2: Move IsBEndMarginRoot() out of LineClampLineIterator, and declare its getters as const. r=#layout
Attachment #9681970 - Attachment description: Bug 2086787: Separate LineClampLineIterator::mConsumedSize into its block start and block end border and padding components. r=#layout → Bug 2086787 Part 3: Separate LineClampLineIterator::mConsumedSize into its block start and block end border and padding components. r=#layout
Attachment #9681971 - Attachment description: Bug 2086787: Refactoring around LineClampLineIterator::Boundary. r=#layout → Bug 2086787 Part 4: Refactoring around LineClampLineIterator::Boundary. r=#layout
Attachment #9671880 - Attachment description: Bug 2086787: Correct handling of collapsing margins in non-auto line-clamp conatainers. r=#layout → Bug 2086787 Part 5: Correct handling of collapsing margins in non-auto line-clamp conatainers. r=#layout
Pushed by salipov@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/58aa74a97c68 https://hg.mozilla.org/integration/autoland/rev/b55b556b9b72 Part 1: Rename and update comments for flags that determine whether line-clamp should apply. r=layout-reviewers,AlaskanEmily https://github.com/mozilla-firefox/firefox/commit/d3002b842467 https://hg.mozilla.org/integration/autoland/rev/14f02f5a441e Part 2: Move IsBEndMarginRoot() out of LineClampLineIterator, and declare its getters as const. r=layout-reviewers,AlaskanEmily https://github.com/mozilla-firefox/firefox/commit/9ca3238e6293 https://hg.mozilla.org/integration/autoland/rev/5258e0443c87 Part 3: Separate LineClampLineIterator::mConsumedSize into its block start and block end border and padding components. r=layout-reviewers,AlaskanEmily https://github.com/mozilla-firefox/firefox/commit/0b08b35e602a https://hg.mozilla.org/integration/autoland/rev/d53f2bca2964 Part 4: Refactoring around LineClampLineIterator::Boundary. r=layout-reviewers,AlaskanEmily https://github.com/mozilla-firefox/firefox/commit/6cc8a8d87516 https://hg.mozilla.org/integration/autoland/rev/8d4bb08585a9 Part 5: Correct handling of collapsing margins in non-auto line-clamp conatainers. r=layout-reviewers,AlaskanEmily

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/65183 for changes under testing/web-platform/tests

Whiteboard: css-line-clamp → css-line-clamp, [wptsync upstream]

The patch landed in nightly and beta is affected.

:salipov, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox161 to wontfix if the fix can wait for the next release.

Uplift requests can be submitted from Lando: D338441, D342231, D342232, D342233, D342234.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(salipov)

Upstream PR merged by moz-wptsync-bot

Regressions: 2093338
Flags: needinfo?(salipov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: