208684 - EnsureBlockDisplay doesn't handle table parts right

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[Hixie (not reading bugmail)]

http://lxr.mozilla.org/seamonkey/source/content/base/src/nsRuleNode.cpp#171 says:

146 static void EnsureBlockDisplay(PRUint8& display)
147 {
...
163   case NS_STYLE_DISPLAY_TABLE_ROW_GROUP :
164   case NS_STYLE_DISPLAY_TABLE_COLUMN :
165   case NS_STYLE_DISPLAY_TABLE_COLUMN_GROUP :
166   case NS_STYLE_DISPLAY_TABLE_HEADER_GROUP :
167   case NS_STYLE_DISPLAY_TABLE_FOOTER_GROUP :
168   case NS_STYLE_DISPLAY_TABLE_ROW :
169   case NS_STYLE_DISPLAY_TABLE_CELL :
170   case NS_STYLE_DISPLAY_TABLE_CAPTION :
171     // special cases: don't do anything since these cannot really be floated 
    anyway
172     break;

It isn't completely clear to me whether that is correct or not. For CELL, for
example, I would suggest it would be better to switch display to block.

(We should probably also check that we correctly handle floating parts inside
tables, checking that they do end up creating a cell around the new float also
wrapping any other non-tabular elements at that point.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed by patch in bug 210873.