Closed
Bug 2086954
Opened 20 days ago
Closed 15 days ago
Migrate `pippki.properties` to Fluent
Categories
(Core :: Security: PSM, task)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 external file)
security/manager/locales/en-US/chrome/pippki/pippki.properties is used almost entirely by front-end code, so it can be migrated to Fluent and removed.
- Page Info security tab strings (
pageInfo_*), used bybrowser/base/content/pageinfo/security.js. I decided to move these tobrowser/pageInfo.ftl. SeaMonkey will be affected, but they need to change code to use the new FTL file anyway (also trying to ping them on Matrix). - Certificate dialog strings (
newCAMessage1,unnamedCA,password_not_set), used bydownloadcert.jsandchangepassword.js, move tosecurity/pippki/pippki.ftl. getPKCS12FilePasswordMessage, used from C++ bynsNSSDialogs.cpp, moves tosecurity/pippki/pippki.ftland is read with a synchronousLocalizationcall, so the string bundle innsNSSDialogscan be removed. I looked at other code, e.g. in DOM, to see how Fluent was used in C++ file (that's the weak spot of this patch, but didn't want to leave the file around with one string).
Several documents also load pippki.properties without using it (pkiBundle in preferences.xhtml, pippki_bundle in clientauthask.xhtml and resetpassword.xhtml); those stringbundles can be removed.
| Assignee | ||
Comment 1•20 days ago
|
||
Also remove unused pippki.properties stringbundles from preferences,
clientauthask and resetpassword.
Pushed by flodolo@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1191846e5e38
https://hg.mozilla.org/integration/autoland/rev/d0583f8c4f48
Migrate pippki.properties strings to Fluent. r=keeler,firefox-desktop-core-reviewers ,fluent-reviewers,settings-reviewers,akulyk,mossop,bolsson
Comment 3•15 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 15 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Updated•9 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•