Closed Bug 2086954 Opened 20 days ago Closed 15 days ago

Migrate `pippki.properties` to Fluent

Categories

(Core :: Security: PSM, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 external file)

security/manager/locales/en-US/chrome/pippki/pippki.properties is used almost entirely by front-end code, so it can be migrated to Fluent and removed.

  • Page Info security tab strings (pageInfo_*), used by browser/base/content/pageinfo/security.js. I decided to move these to browser/pageInfo.ftl. SeaMonkey will be affected, but they need to change code to use the new FTL file anyway (also trying to ping them on Matrix).
  • Certificate dialog strings (newCAMessage1, unnamedCA, password_not_set), used by downloadcert.js and changepassword.js, move to security/pippki/pippki.ftl.
  • getPKCS12FilePasswordMessage, used from C++ by nsNSSDialogs.cpp, moves to security/pippki/pippki.ftl and is read with a synchronous Localization call, so the string bundle in nsNSSDialogs can be removed. I looked at other code, e.g. in DOM, to see how Fluent was used in C++ file (that's the weak spot of this patch, but didn't want to leave the file around with one string).

Several documents also load pippki.properties without using it (pkiBundle in preferences.xhtml, pippki_bundle in clientauthask.xhtml and resetpassword.xhtml); those stringbundles can be removed.

Also remove unused pippki.properties stringbundles from preferences,
clientauthask and resetpassword.

Pushed by flodolo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1191846e5e38 https://hg.mozilla.org/integration/autoland/rev/d0583f8c4f48 Migrate pippki.properties strings to Fluent. r=keeler,firefox-desktop-core-reviewers ,fluent-reviewers,settings-reviewers,akulyk,mossop,bolsson
Status: NEW → RESOLVED
Closed: 15 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Duplicate of this bug: 1760019
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: