Open
Bug 2087250
Opened 18 days ago
Updated 6 hours ago
Mark scanned Firefox Accounts pairing links as opened in a custom tab
Categories
(Firefox for Android :: Accounts and Sync, enhancement)
Tracking
()
ASSIGNED
People
(Reporter: roger, Assigned: corentin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [android-activation-trust] [fxdroid])
Attachments
(1 external file)
Since bug 2068241, IntentReceiverActivity.processIntent opens a scanned pairing link (https://accounts.firefox.com/pair#channel_id=...&channel_key=...&v=2) in AuthCustomTabActivity through launchAuthCustomTab. Knowing that the pairing page is shown in the custom tab allows us to show a different wording.
Proposal: in launchAuthCustomTab, add a query parameter to the pairing URL before building the intent with SupportUtils.createAuthCustomTabIntent.
val url = pairingUrl.buildUpon().appendQueryParameter("embed", "customtab").build()
Notes:
- The pairing data is in the URL fragment. The parameter has to be added with
Uri.Builderso it lands in the query, before#; appending to the string would put it inside the fragment. isFxaPairingLinkruns on the incoming URL before the parameter is added, so the matching from bug 2086039 is unaffected.embed=customtabis a placeholder. The parameter name and value, and whether the/pairpage accepts an unknown query parameter, need to be agreed with the Firefox Accounts team before landing.- Firefox for Android does not otherwise expose to a page that it is shown in a custom tab:
display-modestaysbrowser(it is only changed for installed web apps with a manifest) and the User-Agent matches a normal tab.
| Reporter | ||
Updated•18 days ago
|
Severity: -- → S3
Updated•4 days ago
|
| Reporter | ||
Updated•3 days ago
|
Assignee: nobody → royang
Status: NEW → ASSIGNED
| Reporter | ||
Updated•7 hours ago
|
Assignee: royang → nobody
Status: ASSIGNED → NEW
Comment 1•6 hours ago
|
||
(via GitHub webhook, authenticated as shared-secret)
| Assignee | ||
Updated•6 hours ago
|
Assignee: nobody → cbect
Status: NEW → ASSIGNED
| Assignee | ||
Updated•6 hours ago
|
Points: --- → 1
You need to log in
before you can comment on or make changes to this bug.
Description
•