TRR pre-connect never happens on late beta/release or at Android cold start
Categories
(Core :: Networking: DNS, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox-esr153 | --- | wontfix |
| firefox159 | --- | wontfix |
| firefox160 | --- | wontfix |
| firefox161 | --- | fixed |
People
(Reporter: leggert, Assigned: leggert)
References
Details
(Keywords: regression, Whiteboard: [necko-triaged])
Attachments
(1 external file)
TRRService::MaybeSpeculativeConnectToTRR() (bug 2025145) has three problems:
- It returns early when
TRRConnectionInfo()is null. The cached connection info is only created fromTRR::SendHTTPRequestwhennetwork.trr.async_connInfois set, which is early-beta-or-earlier only, so the pre-connect never happens on late beta and release. - When it does connect, it uses the cached
nsHttpConnectionInfounchanged, while real TRR requests finalize theirs inTRRServiceChannel::ContinueOnBeforeConnect(anonymous,TRR_DISABLED_MODE). The speculative connection therefore appears to land in a differentConnectionEntrythan TRR lookups use. - At Android cold start
GeckoRuntimesendsgeckoview-initial-foregroundinstead ofapplication-foreground, so no pre-connect is attempted. In TRR-first mode the confirmation query fromTRRService::Initopens the connection early; in TRR-only mode, or withnetwork.trr.confirmationNS=skip, nothing does.
Proposed fix: create the connection info on demand and finalize it with the flags TRR requests use, skip the pre-connect when network.trr.use_ohttp is set, and also pre-connect on geckoview-initial-foreground.
Comment 1•19 days ago
|
||
Set release status flags based on info from the regressing bug 2025145
Updated•19 days ago
|
| Assignee | ||
Comment 2•16 days ago
|
||
Updated•16 days ago
|
| Assignee | ||
Comment 3•15 days ago
|
||
Bug 2025145 did not regress this, this never worked even before that change.
| Assignee | ||
Updated•15 days ago
|
Comment 5•15 days ago
|
||
| bugherder | ||
Comment 6•15 days ago
|
||
The patch landed in nightly and ESR is affected.
:leggert, please make an uplift decision for ESR:
- For ESR, nominate the patch for the appropriate ESR uplift approval if the fix should be included in ESR, or set the ESR status flag(s) to
wontfixif an uplift isn't needed. Each affected ESR release needs a decision.
Uplift requests can be submitted from Lando: D338706.
See Requesting an Uplift for documentation on how to request an uplift.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 7•14 days ago
|
||
I want to let this soak in Nightly/Beta for a while first.
Updated•8 days ago
|
| Assignee | ||
Updated•3 days ago
|
Description
•