Closed Bug 2087548 Opened 17 days ago Closed 16 days ago

Shortcut value for View -> Exit Full Screen is not maintained in about:keyboard after restart.

Categories

(Core :: Widget: Cocoa, defect)

Firefox 161
Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
161 Branch
Tracking Status
firefox161 --- verified

People

(Reporter: mchiorean, Assigned: spohl)

References

Details

Attachments

(1 file, 1 external file)

Attached image 2026-10-30_17h55_37.png —

Found in

  • version: 161.0a1

Affected versions

  • versions: 161.0a1

Tested platforms

  • Affected platforms: Mac
  • Unaffected platforms: Windows, Ubuntu

Steps to reproduce

  1. Set a shortcut for View -> Exit Full Screen in System settings
  2. On about:keyboard do a page refresh - shortcut is correctly updated
  3. Restart Firefox and check the about:keyboard page for View -> Exit Full Screen shortcut

Expected result

  • Shortcut should be correctly displayed after restart in about:keyboard.

Actual result

  • Default Firefox value for shortcut is displayed after restart, but it does not work, shortcut set on System Settings works.

Notes

  • Same issue for Enter Reader View shortcut.

Regression range

  • Not a regression recently implemented.

A hidden menu item, such as "Exit Full Screen" outside of full screen, is not in its native menu, and AppKit only applies an assigned shortcut to an item that has been added to a menu. So after a restart, about:keyboard showed the built-in shortcut for these items. A hidden item with a key element is now added to its own menu, hidden, for a moment, so that AppKit applies the assignment, which the item keeps once removed.

Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/dff5d0ac1012 https://hg.mozilla.org/integration/autoland/rev/f698bad58264 Copy a shortcut assigned in System Settings to the key element of a hidden menu item. r=mac-reviewers,bradwerth
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch

Verified on Mac 27 using Firefox build 161.0a1(20261103080110) that shortcut is updated after restart in about:keyboard and that shortcut works correctly. One issue that still reproduces is that shortcut is not updated in about:keyboard before restart but that is covered by bug 2086604.

Marking issue as verified in Nightly 161.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: