Open Bug 2087565 Opened 17 days ago Updated 13 days ago

Shortcut value for ‘History-Search Tabs’ is updated in about:keyboard only after second page refresh.

Categories

(Core :: Widget: Cocoa, defect)

Firefox 161
Desktop
macOS
defect

Tracking

()

ASSIGNED
Tracking Status
firefox161 --- affected

People

(Reporter: mchiorean, Assigned: spohl)

References

Details

Attachments

(1 external file)

Found in

  • version: 161.0a1(20261030090406)

Affected versions

  • versions: 161.0a1

Tested platforms

  • Affected platforms: Mac
  • Unaffected platforms: Windows, Ubuntu

Steps to reproduce

  1. Set a shortcut for History-Search Tabs in System settings
  2. On about:keyboard do a page refresh - shortcut is not updated
  3. On about:keyboard do a new page refresh - shortcut is correctly updated

Expected result

  • Shortcut should be correctly displayed after first page refresh.

Actual result

  • Shortcut for ‘History-Search Tabs’ is updated in about:keyboard page only after second refresh.

Notes

  • Same issue for ‘Show all History’/’Show Recent History’ shortcuts. After Firefox restart shortcut value is correctly displayed in about:keyboard.
  • Same issue for Bookmarks shortcuts.

Regression range

  • Not a regression recently implemented.
Assignee: nobody → spohl.mozilla.bugs
Severity: -- → S3
Status: NEW → ASSIGNED

I have not been able to reproduce this, but I'm going to post a patch that simply observes changes to these shortcuts and updates them in about:keyboard without requiring a page refresh.

A shortcut assigned in macOS System Settings reaches the key element some time after the change, so about:keyboard could show the old one until it was reloaded again. It now updates a row when the shortcut of its key element changes, using the "shortcutchange" event from bug 2087737.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: