Closed
Bug 2087597
Opened 17 days ago
Closed 13 days ago
Allow widget registry entries to show a placeholder until they have a document
Categories
(Firefox :: Widgets, enhancement)
Firefox
Widgets
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt][hnt-wattle])
Attachments
(1 external file)
MozWidgetCard frames a widget's document, but for a registry entry that has no document yet it draws an empty card.
This shows a "Watch this space" placeholder (newtab-widget-placeholder, in newtabPreview.ftl) in the card's default slot whenever it has no document to frame. Once an entry gets a document, either as its src or through a train-hop config src, the card frames it instead.
The Wrexham AFC widget (bug 2087516) needs this until the endpoint it will frame is available.
Updated•17 days ago
|
| Assignee | ||
Comment 1•17 days ago
|
||
MozWidgetCard shows "Watch this space" in place of the widget while its
registry entry has no document to frame. This is meant as a fallback while
framed widgets using MozWidgetCard are built out.
Updated•17 days ago
|
Attachment #9671810 -
Attachment description: WIP: Bug 2087597 - Show a placeholder in a widget card that has no document. → WIP: Bug 2087597 - Show a placeholder in a widget card that has no document. r?nina-py!
Updated•17 days ago
|
Assignee: nobody → mconley
Attachment #9671810 -
Attachment description: WIP: Bug 2087597 - Show a placeholder in a widget card that has no document. r?nina-py! → Bug 2087597 - Show a placeholder in a widget card that has no document. r?nina-py!
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8ea34b353cb0
https://hg.mozilla.org/integration/autoland/rev/09acf88cceec
Show a placeholder in a widget card that has no document. r=nina-py,fluent-reviewers,bolsson
Comment 3•14 days ago
|
||
Backed out for causing failure @ browser_wrexhamafc_widget.js
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8d29e20ff7b3
https://hg.mozilla.org/integration/autoland/rev/69703ff99b85
Show a placeholder in a widget card that has no document. r=nina-py,fluent-reviewers,bolsson
Comment 5•13 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Updated•7 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•