Closed Bug 2087835 Opened 19 days ago Closed 7 days ago

Replace SVG mapped-attribute rules without selector matching

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: mayankleoboy1, Assigned: mayankleoboy1, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

No description provided.

Schedule a normal-traversal replacement hint for SVG mapped attributes,
leaving HTML mapped attributes on the existing full-restyle path. Normal
selector invalidation can still request matching independently.

Replace the entire presentational-hint segment so SVG links keep their
additional link-color hints in both visited modes. When hint identities
are unchanged, reuse the rule path without allocating temporary storage,
cloning rule-node references, or doing rule-tree lookups, and still
recascade the declarations that may have changed in place. Rebuild the
higher-priority path only when the hint list changes. Preserve adjacent
hint deduplication and the display:none animation-traversal guard.

Keep the existing inline-style and animation rule-replacement fast paths.

For non-link SVG elements whose visited and unvisited rule paths are
identical, perform replacements once and reuse the resulting path for
visited cascading. Leave unchanged paths alone without extra refcount
operations. SVG links still replace their visited-dependent hints
separately.

Assignee: nobody → mayankleoboy1
Status: NEW → ASSIGNED
Attachment #9672101 - Attachment description: WIP: Bug 2087835 - Replace SVG mapped-attribute rules without selector matching. → Bug 2087835 - Replace mapped-attribute rules without selector matching.
Attachment #9672101 - Attachment description: Bug 2087835 - Replace mapped-attribute rules without selector matching. → Bug 2087835 - Replace mapped-attribute rules without selector matching. r=#style
Blocks: speedometer3

Rather than introducing pres hint declarations, just map them to the
system colors that we use in the UA sheet. This is a lot simpler.

Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ea9849553999 https://hg.mozilla.org/integration/autoland/rev/d2d78009d04d Replace mapped-attribute rules without selector matching. r=firefox-style-system-reviewers,layout-reviewers,dshin
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6db3c6d75884 https://hg.mozilla.org/integration/autoland/rev/2e7d339fc6fd Simplify how we deal with the vlink/etc legacy attributes. r=firefox-style-system-reviewers,layout-reviewers,jwatt
Status: ASSIGNED → RESOLVED
Closed: 7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

ni? to try to spec + add tests for comment 5 as per the discussion in the WHATNOT meeting.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: