2087836 - Skip style sharing for SVG elements with mapped declarations

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Mayank Bansal]

Attachment: Bug 2087836 - Skip style sharing for elements with mapped declarations.

SVG mapped declaration blocks are owned by individual elements, so their presentation hints cannot pass the pointer-identity comparison against another element. Avoid admitting these elements as sharing candidates or searching nonempty sharing caches for them. Reuse the existing mapped-declaration binding and preserve the existing early rejection paths.

Comment 2

[Mayank Bansal]

sp3 : https://perf.compare/compare-results?baseRev=56b72bcb16530ccf48ee911e709b3651ad8d0c5f&baseRepo=try&newRev=1a25cbc9f8ae6175525008dc6a4609a02d1e2b76&newRepo=try&framework=1&framework=13&sort=median-diff%7Cdesc&initialized=1
try: https://treeherder.mozilla.org/jobs?repo=try&revision=e73a737db9448cd860bbfa8a4a97ca7f7e58ff81

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4f95ed3e77c7
https://hg.mozilla.org/integration/autoland/rev/c4ffba17ddfc
Skip style sharing for elements with mapped declarations. r=firefox-style-system-reviewers,emilio

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c4ffba17ddfc

Comment 5

[BMO Github Automation]

Authored by https://github.com/mayankleoboy
https://github.com/mozilla/enterprise-firefox/commit/4f95ed3e77c7bc459a9eb4fa07444f7728e556c5
[enterprise-main] Bug 2087836 - Skip style sharing for elements with mapped declarations. r=firefox-style-system-reviewers,emilio

(via GitHub webhook, authenticated as shared-secret)

Comment 6

[Performance Sheriff Bot]

Perfherder has detected a browsertime performance change from push c4ffba17ddfcf8636cad7d5906ca27150689e085.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
1%	speedometer3 React-Stockcharts-SVG/total (doc)	macosx1500-aarch64-nightlyasrelease	fission webrender	40.87 ms -> 40.38 ms	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.