[loong64] Clean up method delegation in Loong64's MacroAssembler
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: csmantle, Assigned: csmantle)
References
(Blocks 1 open bug)
Details
Attachments
(10 external files)
Currently, some methods in MacroAssembler for Loong64, especially those of the shared interface, use hand-rolled immediate loading and instruction selection.
For example, MacroAssembler::addPtr(ImmWord imm, Register dest) should have been one single call to MacroAssemblerLOONG64::ma_add_d(Register rd, Register rj, ImmWord imm), instead of the current temps.Acquire(); movePtr(); addPtr() sequence.
Cleaning these up would help their callers enjoy the existing, smarter isel, and also unify future optimizations into one centralized site.
| Assignee | ||
Comment 1•17 days ago
|
||
| Assignee | ||
Comment 2•17 days ago
|
||
| Assignee | ||
Comment 3•17 days ago
|
||
| Assignee | ||
Comment 4•17 days ago
|
||
| Assignee | ||
Comment 5•17 days ago
|
||
storePtr(ImmWord, ...) is kept untouched, which is consistent with
RISCV64's current approach.
| Assignee | ||
Comment 6•17 days ago
|
||
| Assignee | ||
Comment 7•17 days ago
|
||
| Assignee | ||
Comment 8•17 days ago
|
||
| Assignee | ||
Comment 9•17 days ago
|
||
| Assignee | ||
Comment 10•17 days ago
|
||
This is pure hygiene, since mozilla:BitwiseCast is currently
transitively pulled in.
Comment 11•15 days ago
|
||
Comment 12•15 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ea04f3bf5cd0
https://hg.mozilla.org/mozilla-central/rev/31f61eceed8a
https://hg.mozilla.org/mozilla-central/rev/7191e4fec8ec
https://hg.mozilla.org/mozilla-central/rev/2a2cd5edfcf0
https://hg.mozilla.org/mozilla-central/rev/e028dada5dd8
https://hg.mozilla.org/mozilla-central/rev/2ac0f9d080c5
https://hg.mozilla.org/mozilla-central/rev/71353581275d
https://hg.mozilla.org/mozilla-central/rev/00b439c5f047
https://hg.mozilla.org/mozilla-central/rev/8e24ad8f153e
https://hg.mozilla.org/mozilla-central/rev/2f38afde114f
Updated•8 days ago
|
Description
•