Closed Bug 2087972 Opened 17 days ago Closed 8 days ago

Closing the last private window wipes the persistent Alt-Svc cache

Categories

(Core :: Networking: HTTP, defect, P2)

defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: mail, Assigned: afucks)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 external file)

On last-pb-context-exited, nsHttpHandler::Observe calls AltSvcCache::ClearAltServiceMappings(), which calls nsIDataStorage::Clear(). In security/manager/ssl/data_storage/src/lib.rs, clear() empties the persistent, private and temporary tables and deletes AlternateServices.bin.

Fix: remove the ClearAltServiceMappings() call from the last-pb-context-exited branch and add a test that a persistent mapping survives the notification while a private one does not.

See Also: → 2087973

Great, in favor! Manuel and I were just talking about this when we saw that you already filed the bug.

Severity: -- → S3
See Also: → 2088848
Assignee: nobody → afucks
Status: NEW → ASSIGNED

The nsIDataStorage also listens to last-pb-context-exited and clears the
private storage. Clearing the alt-svc mappings in nsHttpHandler was
therefore redundant and removed more entries than necessary.

Pushed by mail@max-inden.de: https://github.com/mozilla-firefox/firefox/commit/03b0ffd96184 https://hg.mozilla.org/integration/autoland/rev/5afe120376c6 Don't wipe persistent alt-svc cache when closing last private window r=mxinden,necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: