Closed Bug 2087974 Opened 15 days ago Closed 13 days ago

No css explainers for attr() using type()

Categories

(DevTools :: Inspector: Rules, defect, P2)

defect

Tracking

(firefox161 fixed)

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 external file)

Attached file test_case.html —

Steps to reproduce
0. With devtools.inspector.css-explainers set to true

  1. Open attached test case
  2. Inspect "Hello"
  3. In the rule view, spot the color declaration in the h1 rule

Expected results

I can hover the attr keyword to display the CSS explainers tooltip

Actual results

Hovering the attr keyword doesn't trigger the tooltip


We should check what's happening in the OutputParser in this case

Component: Inspector → Inspector: Rules

I can actually reproduce with this simpler page data:text/html;charset=utf-8,<!doctype html><body><style>h1 {%0A background: gold;%0A height: attr(h type(<length>));%0A}%0A</style><h1 h=10em>Hello</h1></body> which doesn't involve var()

No longer blocks: 2087964
Summary: No css explainers for attr() using var() to get the attribute name → No css explainers for attr() using type()
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d0a271892f17 https://hg.mozilla.org/integration/autoland/rev/ec4303459f24 [devtools] Add CSS explainers for attr() using type(). r=devtools-reviewers,ochameau.
Severity: -- → S3
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: