[PP] Password revealed in form password field

VERIFIED FIXED in M2

Status

()

Core
Layout: Form Controls
P2
normal
VERIFIED FIXED
20 years ago
19 years ago

People

(Reporter: Steve Lamm, Assigned: Eric Pollmann)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

20 years ago
Password characters are not replace with *'s in form password fields.

Build stats:
----------------------------------------------------
Linux: The test platform.
Windows: The benchmark platform.
Both builds from 12-29-98.
Linux Red Hat 5.2
egcs-2.90.29 980515 (egcs-1.0.3 release)
gtk+-1.1.9
ramiro's nspr rpm with pthreads
../mozilla/configure  --enable-debug --with-pthreads
16-bit display
(Reporter)

Updated

20 years ago
Summary: [PP] Password revealed in form password entry field → [PP] Password revealed in form password field

Updated

20 years ago
Assignee: trudelle → karnaze

Updated

20 years ago
Assignee: karnaze → pollmann

Comment 1

20 years ago
This works in the widget test program.  Someone please look into this.  The
NS_METHOD  nsTextHelper::SetPassword(PRBool aIsPassword) call is never being
made by the layout stuff.
(Assignee)

Updated

20 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

20 years ago
When forms create a password input, mIsPassword is passed through InitData,
therefore SetPassword is never called.

We just need to add this method, as it is in the windows widget.  I'll do the
work of adding it once I can test again (some recent checkin busted my Linux
tree).

NS_METHOD nsTextHelper::PreCreateWidget(nsWidgetInitData *aInitData)
{
  if (nsnull != aInitData) {
    nsTextWidgetInitData* data = (nsTextWidgetInitData *) aInitData;
    mIsPassword = data->mIsPassword;
    mIsReadOnly = data->mIsReadOnly;
  }
  return NS_OK;
}
(Assignee)

Updated

20 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

20 years ago
Just checked in a fix.

Updated

20 years ago
Status: RESOLVED → VERIFIED

Comment 4

20 years ago
verified in 1/26 build.

Comment 5

20 years ago
Inserting Milestone info.

Comment 6

19 years ago
Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze.  Widget Set component will be retired
shortly.
You need to log in before you can comment on or make changes to this bug.