Closed Bug 2088010 Opened 15 days ago Closed 13 days ago

Enable clip paths in WebRender when using SWGL

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: nical, Assigned: nical)

References

Details

Attachments

(3 external files)

No description provided.

It matches the behavior of the ssaa4/ssaa8 versions of the original shader.

For now path rendering is only done as a clip (by masking out pixels in an
intermediate target with the premultiplied-dest-out blend mode), so SWGL's
fast path focuses on that. At some point we will adapt this to be able to
blend colors directly into the destination target.

Assignee: nobody → nical.bugzilla
Status: NEW → ASSIGNED

By default the compiler emmits (non-inlined) libm function calls instead of roundss
instructions (unless SSE4.1 is enabled at build time which isn't the case for us).

Rather than attempt to match libm's behavior, this matches SWGL's vector versions.
So it won't behave well for values outside of the int32 range (but will misbehave
in a way consistent with the vector versions).

On a clip-path heavy test case this reduces the total time spent clipping by about 3%,
which is significant because few pixels hit the code path that calls ceil (but the
ones that do, call ceil 8 times per pixel).

Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: