Closed
Bug 2088071
Opened 18 days ago
Closed 18 days ago
glean_parser: ALL_OBJECT_CHECKS (UNKNOWN_PING_REFERENCED and NAME_TOO_SIMILAR) never actually run
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Data Platform and Tools
Glean: SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: janerik, Assigned: janerik)
References
Details
(Whiteboard: [telemetry:glean-rs:m?])
Attachments
(1 external file)
The ALL_OBJECT_CHECKS (namely NAME_TOO_SIMILAR and UNKNOWN_PING_REFERENCED) never actually run.
Bug 2088014 for example removes a ping mention because the linter did not catch it earlier.
That's (probably) because of these checks: https://github.com/mozilla/glean_parser/blob/09aa62d1eb01064c895effef9aff6cfee17f4d77/glean_parser/lint.py#L644-L650
| Assignee | ||
Updated•18 days ago
|
Assignee: nobody → jrediger
Priority: P3 → P1
Comment 1•18 days ago
|
||
(via GitHub webhook, authenticated as shared-secret)
| Assignee | ||
Comment 2•18 days ago
|
||
badboy merged PR [mozilla/glean_parser]: Bug 2088071 - Ensure ALL_OBJECT_CHECKS actually run against the known items (#888) in a60e827.
Status: NEW → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•