Closed
Bug 2088158
Opened 17 days ago
Closed 14 days ago
Move Wrexham widget strings out from newtabPreview.ftl to newtab.ftl
Categories
(Firefox :: Widgets, task)
Firefox
Widgets
Tracking
()
RESOLVED
FIXED
162 Branch
People
(Reporter: mconley, Assigned: mconley, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt][hnt-wattle])
Attachments
(2 external files)
Once we're confident that we have the right strings, we should do this. We should definitely do this before 161 merges to Beta (3 days from now).
Updated•17 days ago
|
| Assignee | ||
Comment 1•15 days ago
|
||
Updated•15 days ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a0bb2db0a2e3
https://hg.mozilla.org/integration/autoland/rev/952039abe7f2
Move Wrexham AFC widget strings out from preview into newtab.ftl for localization. r=fluent-reviewers,fchasen,bolsson
| Assignee | ||
Comment 3•14 days ago
|
||
Frustratingly, this did not make the Beta merge. I'm going to request uplift as soon as Lando lets me.
Flags: needinfo?(mconley)
Comment 4•14 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
| Assignee | ||
Comment 5•14 days ago
|
||
[Tracking Requested - why for this release]:
We need these strings to be localized (at least in Welsh) for the Wrexham repack widget, and unfortunately I just missed the merge. :/
tracking-firefox161:
--- → ?
Updated•13 days ago
|
status-firefox161:
--- → affected
Comment 6•13 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: The Wrexham widget for the Wrexham repack will not have the opportunity to be localized in Welsh.
- Code covered by automated testing?: no
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: This simply moves strings out of preview into the localization pipeline.
- String changes made/needed?: Yes, very much so.
- Is Android affected?: no
Attachment #9675727 -
Flags: approval-mozilla-beta?
| Assignee | ||
Comment 7•13 days ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D339526
Comment 8•13 days ago
|
||
OK to uplift this due to the limited locales this would be exposed to. I'll follow-up with the Welsh team to let them know.
Updated•13 days ago
|
Attachment #9675727 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•13 days ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•