Closed
Bug 2088285
Opened 17 days ago
Closed 16 days ago
Remove HeadlessLookAndFeelGTK
Categories
(Firefox :: Headless, task)
Firefox
Headless
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 external file)
We taught nsLookAndFeel to not crash when no GTK settings were available in bug 1535790.
| Assignee | ||
Comment 1•17 days ago
|
||
It used to be the case that nsLookAndFeel didn't deal with no gtk
settings and crashed but now we can do the same thing we do on all
platforms and just use the platform settings as needed.
Tweak some defaults when there are no settings to match the old
behavior, and make colors fall back to stand-ins.
Pushed by ealvarez@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/6cc344f4f397
https://hg.mozilla.org/integration/autoland/rev/b6130aec93fd
Remove HeadlessLookAndFeelGTK. r=stransky,gtk-reviewers
Comment 3•17 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 17 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Pushed by smolnar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/69d4eaf1d24e
https://hg.mozilla.org/integration/autoland/rev/a78c8aeda4b4
Revert "Bug 2088285 - Remove HeadlessLookAndFeelGTK. r=stransky,gtk-reviewers" for causing mochitest headless failures/crashes
Comment 5•17 days ago
|
||
Backed out for causing mochitest headless failures/crashes
Backout link: https://hg.mozilla.org/integration/autoland/rev/a78c8aeda4b4b3f3951a45c1e9d73d69978a0432
Status: RESOLVED → REOPENED
status-firefox161:
fixed → ---
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Target Milestone: 161 Branch → ---
| Assignee | ||
Updated•17 days ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8e8c8b33b6e6
https://hg.mozilla.org/integration/autoland/rev/816bc0ccb9b9
Remove HeadlessLookAndFeelGTK. r=stransky,gtk-reviewers
Comment 7•16 days ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 17 days ago → 16 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/93bf8e77cc16
https://hg.mozilla.org/integration/autoland/rev/621dc09bf436
Fix test_textScaleFactor_system_font expectations.
Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/13dc3126ab91
https://hg.mozilla.org/integration/autoland/rev/1ef4953a8e8f
Make select_on_focus remain true for headless.
Comment 10•16 days ago
|
||
| bugherder | ||
Updated•11 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•