208872 - cloneNode doesn't copy style attribute correctly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[mikol]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030609 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030609 Mozilla Firebird/0.6

Here's the HTML code in question:

<td colspan="2" nowrap="1">
  <div>
    <span style="font-weight:normal;float:right;">
      <span id="remDevLink"><a id="rem" href="">Remove...</a> | </span>
      <a id="mod" href="">Edit...</a>
    </span>
    <span id="dev">Floppy Drive</span>
  </div>
</td>

The float and font-weight style in td.div.span is not honored.

Reproducible: Always

Steps to Reproduce:
I don't have a small test case, but it happens every time for the page you'll
find in the attached screenshots.


Expected Results:  
See the expected results (Mozilla 1.3.1) screenshot.

Comment 1

[mikol]

Attachment: Expected Layout (Mozilla 1.3.1)

Comment 2

[mikol]

Attachment: Actual Layout (Gecko/20030609 Mozilla Firebird/0.6)

Comment 3

[Boris Zbarsky [:bzbarsky]]

So... how do I load this page the screenshots are of?  Would it be possible to
save it and attach it to this bug?

Comment 4

[mikol]

I'm afraid not. The problem being that the page is constructed from a template
using the DOM to clone sections of interest. I did load the template in
Gecko/20030609 Mozilla Firebird/0.6 by itself. The float and font-weight
specifications are honored in the template, but (obviously) not after the parts
have been replicated in the DOM. Might be a DOM problem. I will try to create a
self-contained example to demonstrate the problem.

Comment 5

[mikol]

Attachment: Test Case

Comment 6

[mikol]

The problem in question can be seen by clicking "Demonstrate Problem" on the
index.html page contained in the Test Case attachement.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified testcase

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a regression from my bug 125246 landing.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes it.	The copying of mStyleBits is the fix.  The other three changes
are two potential UMR/crash fixes and a warning fix that I'd already attached
to another bug.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: more thorough testcase

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125329 [details] [diff] [review]
patch

r+sr=me.  [e-mail], thanks for the bug report and the testcase!

Comment 12

[mikol]

[e-mail], not a problem. Thanks for the quick response.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-06-10 15:08 -0700.