Closed Bug 2088844 Opened 15 days ago Closed 12 days ago

Some container menus and the contextualIdentities API use different container colors than the rest of the Nova UI

Categories

(Firefox :: Containers, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 2074327

People

(Reporter: dao, Unassigned)

References

Details

With bug 2074327, Nova paints container icons, names and the tab line with --identity-stroke-color from usercontext.css. codeNova in CONTAINER_COLORS (ContextualIdentityService.sys.mjs) still holds the --color-<name>-40 values, so everything that reads getContainerColorCode() shows a different shade:

  • the panel-list container menu built in utilityOverlay.js, which sets --panel-item-fill inline
  • the address bar's container submenu (#populateContainerSubmenu in UrlbarView.mjs)
  • the colorCode that the contextualIdentities extension API returns

In light mode, --identity-stroke-color against codeNova:

color --identity-stroke-color codeNova
blue rgb(69, 95, 231) #5a87fd
green rgb(0, 136, 101) #11ae84
yellow rgb(243, 168, 30) #db820e
violet rgb(118, 78, 221) #9871ff

Yellow, violet and gray also differ in dark mode. A single hex value cannot express a light/dark pair, so the menus may need to take the color from the identity-color-* class instead. The comment above CONTAINER_COLORS saying codeNova matches the tab stroke needs updating either way.

container_color_codes_match_css in browser_container_definitions_in_sync.js asserts that codeNova matches the CSS container color, and it fails with https://phabricator.services.mozilla.com/D334717 for blue, green, yellow and violet. So codeNova needs the new light-mode values in that patch. This bug can stay open for the dark-mode mismatch that a single hex value can't express.

Blocks: 2074327
No longer depends on: 2074327

The fix landed in bug 2074327.

Status: NEW → RESOLVED
Closed: 12 days ago
Duplicate of bug: 2074327
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.