Open Bug 2088847 Opened 16 days ago Updated 3 hours ago

Remove stale SSL token cache prefs from tests

Categories

(Core :: Networking, task, P3)

task

Tracking

()

ASSIGNED

People

(Reporter: leggert, Assigned: raus7n)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [necko-triaged])

Attachments

(1 external file)

Several tests still set prefs that no longer exist, so the calls have no effect:

  • network.ssl_tokens_cache_enabled was removed in bug 1720118 (the TLS token cache is always used). It is still set (and cleared) in:
    • security/manager/ssl/tests/unit/test_session_resumption.js
    • netwerk/test/unit/test_retry_0rtt.js
    • netwerk/test/unit/test_happy_eyeballs_h1_0rtt.js
    • netwerk/test/unit/test_happy_eyeballs_h2_0rtt.js
    • netwerk/test/unit/test_happy_eyeballs_0rtt_fallback.js
    • netwerk/test/unit/test_happy_eyeballs_0rtt_h1_reject.js
    • netwerk/test/unit/test_happy_eyeballs_0rtt_abandoned_requeueed.js
  • network.ssl_tokens_cache_use_only_once was removed in bug 1861878. It is still set in netwerk/test/gtest/TestSSLTokensCache.cpp.

Remove the setBoolPref / clearUserPref / Preferences::SetBool calls for these prefs. Neither pref is defined in StaticPrefList.yaml or all.js, so nothing reads them and the tests should behave the same afterwards.

To verify, run the affected tests before and after, e.g. ./mach xpcshell-test netwerk/test/unit/test_retry_0rtt.js and ./mach gtest "TestTokensCache.*".

Blocks: 2046859
Assignee: nobody → raus7n
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Whiteboard: [necko-triaged]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:raus7n, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(raus7n)
Flags: needinfo?(kershaw)
Flags: needinfo?(kershaw)

Thanks for the review, Kershaw. I’ve restored the testing-exception-unchanged tag on D339494. The patch is marked Check-in Needed. Could you help land it?

Flags: needinfo?(raus7n)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: