Remove stale SSL token cache prefs from tests
Categories
(Core :: Networking, task, P3)
Tracking
()
People
(Reporter: leggert, Assigned: raus7n)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged])
Attachments
(1 external file)
Several tests still set prefs that no longer exist, so the calls have no effect:
network.ssl_tokens_cache_enabledwas removed in bug 1720118 (the TLS token cache is always used). It is still set (and cleared) in:security/manager/ssl/tests/unit/test_session_resumption.jsnetwerk/test/unit/test_retry_0rtt.jsnetwerk/test/unit/test_happy_eyeballs_h1_0rtt.jsnetwerk/test/unit/test_happy_eyeballs_h2_0rtt.jsnetwerk/test/unit/test_happy_eyeballs_0rtt_fallback.jsnetwerk/test/unit/test_happy_eyeballs_0rtt_h1_reject.jsnetwerk/test/unit/test_happy_eyeballs_0rtt_abandoned_requeueed.js
network.ssl_tokens_cache_use_only_oncewas removed in bug 1861878. It is still set innetwerk/test/gtest/TestSSLTokensCache.cpp.
Remove the setBoolPref / clearUserPref / Preferences::SetBool calls for these prefs. Neither pref is defined in StaticPrefList.yaml or all.js, so nothing reads them and the tests should behave the same afterwards.
To verify, run the affected tests before and after, e.g. ./mach xpcshell-test netwerk/test/unit/test_retry_0rtt.js and ./mach gtest "TestTokensCache.*".
| Assignee | ||
Comment 1•16 days ago
|
||
Updated•16 days ago
|
Updated•10 days ago
|
Comment 2•2 days ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 1 week.
:raus7n, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Updated•22 hours ago
|
| Assignee | ||
Comment 3•4 hours ago
|
||
Thanks for the review, Kershaw. I’ve restored the testing-exception-unchanged tag on D339494. The patch is marked Check-in Needed. Could you help land it?
Description
•