Terms of Use "Continue" button is taller than the buttons on the other onboarding pages
Categories
(Firefox for Android :: Onboarding, defect, P1)
Tracking
()
People
(Reporter: towhite, Assigned: towhite)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [android-activation-trust] [fxdroid])
Attachments
(1 external file)
The primary button on the Terms of Useonboarding page is 48dp tall, while the primary and secondary buttons on the other onboarding pages are 40dp, matching the Figma design. This makes the Terms of Use page visually inconsistent with the rest of onboarding.
Bug 2021560 introduced the extra height by adding .defaultMinSize(minHeight = FirefoxTheme.layout.size.static600) to the FilledButton in TermsOfServiceOnboardingPage.kt, to preserve a 48dp touch target on small screens.
The button should retain a 48dp touch target without increasing its 40dp visual height. FilledButton wraps the Material 3 Button, which already reserves a minimum interactive size through minimumInteractiveComponentSize(). Compose also expands pointer hit testing for undersized touch targets, and neither Acorn nor Fenix overrides LocalMinimumInteractiveComponentSize.
Remove the defaultMinSize modifier and its unused import from TermsOfServiceOnboardingPage.kt, matching OnboardingPage.kt. Verify that the button retains its touch target on small screens. If the layout issue from bug 2021560 still occurs, adjust the page so the scrollable body shrinks before the button is constrained.
Updated•14 days ago
|
Comment 1•14 days ago
|
||
(via GitHub webhook, authenticated as shared-secret)
Comment 2•14 days ago
|
||
Set release status flags based on info from the regressing bug 2021560
Comment 3•14 days ago
|
||
| frontend-triage | ||
The analysis in comment 0 is right. The regressor (D291410, hg 4ef80f8c038b) added exactly two lines: the defaultMinSize import and .defaultMinSize(minHeight = FirefoxTheme.layout.size.static600) (48dp) on the FilledButton. Both are still in TermsOfServiceOnboardingPage.kt, at line 14 and lines 117-125. The fix in the attached PR is the right one: remove both lines so the button matches OnboardingPage.kt. From reading the code:
- Acorn's
FilledButton(Button.kt) wraps the M3Buttonand sets no height of its own. Nothing on the onboarding path overridesLocalMinimumInteractiveComponentSize; the only override undermobile/android/is in the summarize settings screen. So without the modifier, the button should be 40dp visually with a 48dp touch target, as on the other onboarding cards. - The page can't squeeze the button. It is the only child of the page's Column without a weight, so Compose measures it first and the weighted scroll
Boxgives up space instead. On small devices the card gets the full window height, so the bug 2021560 layout concern shouldn't come back. - One thing to check on a device: the Accessibility Scanner reported 47dp in bug 2021560 (Soyes XS16, Android 10). That isn't explained by the button being 40dp, so it may be px rounding of the 48dp touch bounds at that density. Re-scan on a similar low-density device; a 47dp report there would be a scanner artifact, not a regression.
No test checks the button's height. verifyTheTermsOfUseOnboardingCardTest in efficiency/tests/OnboardingTest.kt taps Continue, so it covers the button still working.
Suggested severity: S4. This is a purely visual inconsistency (8dp of extra button height) on one onboarding card; it doesn't affect function.
If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.
Needinfo hackbot@mozilla.tld to have a patch generated for this bug, include any questions or directions as needed in your comment.
Updated•14 days ago
|
Description
•