2089286 - Batch nonbreaking spans and continued words in line-break setup

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Mayank Bansal]

sp3 : https://perf.compare/compare-results?baseRev=2f484e970286be4eff3ac22fe436327107c580f8&baseRepo=try&newRev=071ef2ce258626fc3b709343fdf98290ff34f49d&newRepo=try&framework=1&framework=13&sort=median-diff%7Cdesc&initialized=1
Not the biggest change, about 0.1% on many subtests and maybe overall too.
Posting the patch in case this turns out to be a "obvious improvement to the code".

try: https://treeherder.mozilla.org/jobs?repo=try&revision=a828b24eeb74315e781ab11e53d4e891065adb1b

Comment 1

[Mayank Bansal]

Attachment: Bug 2089286 - Batch nonbreaking spans and continued words in line-break setup.

Scan nonbreaking Latin-1 word interiors without repeating whitespace and
boundary-state work for each character. Fill their break flags in bulk,
retaining word-level Unicode breaking, capitalization and hyphenation.

Append cross-chunk word continuations in bulk for both character widths,
and update the continuation language once per UTF-16 chunk.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4a567730aee6
https://hg.mozilla.org/integration/autoland/rev/c5c753b89108
Batch nonbreaking spans and continued words in line-break setup. r=layout-reviewers,jfkthame

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c5c753b89108