Closed Bug 2089291 Opened 16 days ago Closed 14 days ago

Tabs engine fails to sync with per-device engine choices on a new meta/global

Categories

(Firefox :: Sync, defect)

defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsync-])

Attachments

(1 external file)

With services.sync.perDeviceEngineChoices on, a client that creates meta/global
never publishes the tabs engine. TabEngine's _syncStartup throws:

TypeError: this._bridge.getSyncId is not a function

_resolveEngineMetaPerDevice calls engine.getSyncID() when meta/global and
meta/syncids have no entry for the engine. BridgedEngine.getSyncID() calls
this._bridge.getSyncId(), but the UniFFI tabs bridge only has syncId().
Passwords and extension-storage add a getSyncId shim to their bridges;
tabs doesn't.

Before per-device choices, nothing outside tests called getSyncID(), so
pref-off users aren't affected.

Found by the TPS test test_pds_creates_account.js.

Fix: add the same shim in TabEngine.initialize().

Assignee: nobody → skhamis
Whiteboard: [fxsync-]
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: