Closed Bug 2089301 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64363 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327897

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64363 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64363
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327897

WebKit export from bug: [<!---->Flex]<!----> A stretched item in a column-<!---->reverse wrap flex container ignores its main-<!---->axis auto margin

<pre>
[Flex] A stretched item in a column-reverse wrap flex container ignores its main-axis auto margin

The flex formatting context read the items' margins off their renderers, where item layouts overwrite them from style with auto as 0.
So a stretched item in a column-reverse wrap container lost its main-axis auto margin in its stretch relayout, before computeFlexItemRects read it to flip the item.
FlexLayoutItem now carries the margins, resolved from the item's used style, so its own zoom applies, and updated with the auto margins the algorithm resolves.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327897">https://bugs.webkit.org/show_bug.cgi?id=327897</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324398@main">https://commits.webkit.org/324398@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1565 tests and 168 subtests

Status Summary

Firefox

OK : 2[GitHub] 401[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 7[GitHub] 38[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 5097[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 6113[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 6115[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 6116[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL: 238[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 341[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 345[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 347[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

OK : 2
PASS: 7

Safari

OK : 2
PASS: 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.