Closed Bug 2089303 Opened 14 days ago Closed 6 days ago

[wpt-sync] Sync PR 64362 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328543

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64362 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64362
Details from upstream follow.

Matt Woodrow <mattwoodrow@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328543

WebKit export from bug: REGRESSION(<!---->313316@<!---->main)<!---->:<!----> Map Zoomer slower due to large filter bounds

<pre>
REGRESSION(<a href="https://commits.webkit.org/313316@main">313316@main</a>): Filtered layers with composited ancestor clips allocate oversized filter buffers

<a href="https://commits.webkit.org/313316@main">313316@main</a> changed setupFilters() to call calculateLayerBounds() with empty flags so that descendant
layers would use the default flags, which include IncludeSelfTransform. The defaults also include
UseLocalClipRectIfPossible, which makes each descendant report its ancestor clip rect (relative to the
painting root) as its bounds. On MotionMark Map Zoomer, each 50x66 drop-shadow placard now produced a
400x320 filter buffer, the size of the map's overflow clip.

Add IncludeDescendantTransforms, which adds IncludeSelfTransform to the descendant flags, and use it with
PreserveAncestorFlags in setupFilters(). Descendant transforms are honored without the local clip rect
shortcut, and the filtered layer's own transform is still excluded.

ViewTransition::captureOverflowRect() had the same problem: PreserveAncestorFlags without
IncludeSelfTransform ignored descendant transforms, so transformed descendants were clipped out of the
captured image. Use IncludeDescendantTransforms there too.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328543">https://bugs.webkit.org/show_bug.cgi?id=328543</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324517@main">https://commits.webkit.org/324517@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 535 tests and 1 subtests

Status Summary

Firefox

OK : 158[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 160[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[GitHub] 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1365[Gecko-windows11-32-25h2-debug] 1366[Gecko-windows11-32-25h2-opt] 1617[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1618[Gecko-android-em-14-x86_64-debug-geckoview] 1622[Gecko-windows11-64-25h2-debug] 1623[Gecko-windows11-64-25h2-opt] 1627[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 77[Gecko-windows11-32-25h2-opt] 78[Gecko-windows11-32-25h2-debug] 133[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 137[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-64-25h2-opt] 138[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug]
TIMEOUT: 11[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 13[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR : 2[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 3[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

PASS : 1

Safari

FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.