Closed Bug 2089309 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64370 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318325

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64370 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64370
Details from upstream follow.

Ahmad Saleem <ahmad.saleem792+github@gmail.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318325

WebKit export from bug: feConvolveMatrix:<!----> removing an invalid order attribute leaves the filter permanently disabled

<pre>
feConvolveMatrix: removing an invalid order attribute leaves the filter permanently disabled

When feConvolveMatrix parses an invalid order (e.g. order="0"), it sets
m_hasInvalidOrderAttribute so createFilterEffect() bails out and the filtered
element is not displayed. Removing the order attribute produces an empty value,
which parseNumberOptionalNumber() rejects, so the code took the parse-failure
path and kept m_hasInvalidOrderAttribute set. The filter therefore stayed
disabled even though a missing order attribute is valid and defaults to 3x3.

Treat an empty/absent order value as the valid 3x3 default: reset orderX/orderY
to the initial value and clear m_hasInvalidOrderAttribute, distinct from a
present-but-malformed value which continues to invalidate the primitive.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=318325">https://bugs.webkit.org/show_bug.cgi?id=318325</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/317005@main">https://commits.webkit.org/317005@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Web Painting
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 398 tests and 5 subtests

Status Summary

Firefox

OK : 38
PASS: 1[GitHub] 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3016[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3302[Gecko-windows11-64-25h2-opt] 3305[Gecko-windows11-64-25h2-debug] 3310[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 3312[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 14[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 55[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 57[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 62[Gecko-windows11-64-25h2-debug] 65[Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.