Closed Bug 2089313 Opened 17 days ago Closed 8 days ago

[wpt-sync] Sync PR 64371 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318756

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64371 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64371
Details from upstream follow.

Simon Fraser <simon.fraser@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318756

WebKit export from bug: [<!---->Scroll anchoring]<!----> nfl.<!---->com scroll position jumps when hovering the top bar (<!---->changing scroll-<!---->padding)<!---->

<pre>
[Scroll anchoring] nfl.com scroll position jumps when hovering the top bar (changing scroll-padding)

The scroll anchoring code re-used computeScrollerRelativeRects() for both anchor selection, and
scroll anchoring adjustment. However, only anchor selection should respect scroll-padding; this caused
an erroneous scroll anchoring adjustment on nfl.com when the page changes scroll-padding on the root
when the top bar is hovered.

Fix by passing in a flag to say whether scroll-padding should be respected; off for anchor adjustment,
and on for anchor selection.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=318756">https://bugs.webkit.org/show_bug.cgi?id=318756</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/316662@main">https://commits.webkit.org/316662@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 82 tests

Status Summary

Firefox

OK : 1[GitHub] 71[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 72[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[GitHub] 5[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 88[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 95[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 98[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 99[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 3[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 4[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
TIMEOUT: 1
ERROR : 1

Chrome

OK : 1
PASS : 1

Safari

OK : 1
PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

  • /css/css-scroll-anchoring/start-edge-in-block-layout-direction.html [wpt.fyi]: OK [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.