[wpt-sync] Sync PR 64335 - [WebAudio] Fire processorerror instead of error at AudioWorkletNode
Categories
(Core :: Web Audio, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64335 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64335
Details from upstream follow.
Mahesh Kannan <kmaheshb@google.com> wrote:
[WebAudio] Fire processorerror instead of error at AudioWorkletNode
Ensure addEventListener("processorerror") works on AudioWorkletNode as
prescribed by the WebAudio spec. Previously, AudioWorkletNode
dispatched an ErrorEvent with type "error" and bound onprocessorerror
to "error", so addEventListener("processorerror") never fired.Re-add "processorerror" to event_type_names.json5 and gate switching
both onprocessorerror and the dispatched ErrorEvent type behind the
stable AudioWorkletProcessorErrorEventType flag.Bug: 573625316
Test: audioworkletnode-onerror.https.html
Change-Id: I1029c29ac629cc4885da63194202651ef56649ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8665592
Reviewed-by: Michael Wilson \<mjwilson@chromium.org>
Commit-Queue: Mahesh Kannan \<kmaheshb@google.com>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729803}
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Comment 1•11 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116181
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 41 tests and 3 subtests
Status Summary
Firefox
OK : 1[GitHub] 35[Gecko-android-em-14-x86_64-debug-geckoview] 39[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-opt] 40[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug]
PASS : 2[GitHub] 152[Gecko-android-em-14-x86_64-debug-geckoview] 165[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 173[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR: 1
Chrome
OK : 1
PASS : 1
FAIL : 2
Safari
OK : 1
PASS : 2
FAIL : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-rendersizehint.https.html [wpt.fyi]:
SKIP - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-iterable.https.html [wpt.fyi]
- Values for a control-rate parameter.automationRate match for set:
FAIL - Values for 你好.automationRate match for set:
FAIL - Values for 🎶.automationRate match for set:
FAIL - Values for a control-rate parameter.automationRate match for array:
FAIL - Values for 你好.automationRate match for array:
FAIL - Values for 🎶.automationRate match for array:
FAIL - Values for a control-rate parameter.automationRate match for generator:
FAIL - Values for 你好.automationRate match for generator:
FAIL - Values for 🎶.automationRate match for generator:
FAIL
- Values for a control-rate parameter.automationRate match for set:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-range.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-size.https.html [wpt.fyi]
- Executing "Verify Size of AudioParam Arrays":
FAIL
- Executing "Verify Size of AudioParam Arrays":
- /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam.https.html [wpt.fyi]
- Verifying AudioParam in AudioWorkletNode:
FAIL
- Verifying AudioParam in AudioWorkletNode:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-sharedarraybuffer.https.html [wpt.fyi]:
OK[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/audioworkletglobalscope-timing-info.https.html [wpt.fyi]
- Check the timing information from AudioWorkletProcessor:
FAIL
- Check the timing information from AudioWorkletProcessor:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-channel-count.https.html [wpt.fyi]
- setup-buffer-and-worklet-verify-rendered-buffer:
FAIL
- setup-buffer-and-worklet-verify-rendered-buffer:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-disconnected-input.https.html [wpt.fyi]
- Input array length should be zero for disconnected input:
FAIL
- Input array length should be zero for disconnected input:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html [wpt.fyi]
- Test if |onprocessorerror| is called for an exception thrown from the processor constructor.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Test if |onprocessorerror| is called for an exception thrown from the processor constructor.:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html [wpt.fyi]
- AudioWorkletNode channel count: dynamic propagation and honoring outputChannelCount (single serialized test).:
FAIL
- AudioWorkletNode channel count: dynamic propagation and honoring outputChannelCount (single serialized test).:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-param-getter-overridden.https.html [wpt.fyi]
- Test if AudioWorkletProcessor with invalid parameters array getter:
FAIL
- Test if AudioWorkletProcessor with invalid parameters array getter:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https.html [wpt.fyi]
- X |inputs| is frozen is not true. Got false.:
FAIL - X |outputs| is frozen is not true. Got false.:
FAIL - < [check-frozen-array] 2 out of 2 assertions were failed.:
FAIL -
AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.:
FAIL
- X |inputs| is frozen is not true. Got false.:
- /webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-unconnected-outputs.https.window.html [wpt.fyi]:
ERROR[Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-opt],OK[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-64-25h2-debug] - /webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/process-getter.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview]
Tests Disabled in Gecko Infrastructure
- /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-rendersizehint.https.html [wpt.fyi]:
SKIP - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-range.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-sharedarraybuffer.https.html [wpt.fyi]:
OK[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /webaudio/the-audio-api/the-audioworklet-interface/process-getter.https.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview]
Comment 4•4 days ago
|
||
| bugherder | ||
Description
•