Closed Bug 2089316 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64335 - [WebAudio] Fire processorerror instead of error at AudioWorkletNode

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64335 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64335
Details from upstream follow.

Mahesh Kannan <kmaheshb@google.com> wrote:

[WebAudio] Fire processorerror instead of error at AudioWorkletNode

Ensure addEventListener("processorerror") works on AudioWorkletNode as
prescribed by the WebAudio spec. Previously, AudioWorkletNode
dispatched an ErrorEvent with type "error" and bound onprocessorerror
to "error", so addEventListener("processorerror") never fired.

Re-add "processorerror" to event_type_names.json5 and gate switching
both onprocessorerror and the dispatched ErrorEvent type behind the
stable AudioWorkletProcessorErrorEventType flag.

Bug: 573625316
Test: audioworkletnode-onerror.https.html
Change-Id: I1029c29ac629cc4885da63194202651ef56649ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8665592
Reviewed-by: Michael Wilson \<mjwilson@chromium.org>
Commit-Queue: Mahesh Kannan \<kmaheshb@google.com>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729803}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Web Audio
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 41 tests and 3 subtests

Status Summary

Firefox

OK : 1[GitHub] 35[Gecko-android-em-14-x86_64-debug-geckoview] 39[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-opt] 40[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug]
PASS : 2[GitHub] 152[Gecko-android-em-14-x86_64-debug-geckoview] 165[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 173[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR: 1

Chrome

OK : 1
PASS : 1
FAIL : 2

Safari

OK : 1
PASS : 2
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/adc59309bd22 https://hg.mozilla.org/integration/autoland/rev/09625a36dae3 [wpt PR 64335] - [WebAudio] Fire processorerror instead of error at AudioWorkletNode, a=testonly
Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.