Closed Bug 2089320 Opened 14 days ago Closed 6 days ago

[wpt-sync] Sync PR 64331 - Mark Opaque XR framebuffers as incomplete on session end

Categories

(Core :: WebVR, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 64331 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64331
Details from upstream follow.

Brandon Jones <bajones@chromium.org> wrote:

Mark Opaque XR framebuffers as incomplete on session end

Ensures that Opaque framebuffers created by WebXR are always marked
as incomplete at the end of an XR frame, even if the session ended
during the frame.

As an additional guard against accessing orphaned shared image
texture handles via an opaque framebuffer, ensure that the color
textures are detached from the framebuffer when the frame ends.

Fixed: 578670966
Change-Id: I67525e51b7eaf7cac5703ba2f2c9bd604aa53b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8665766
Reviewed-by: Brian Sheedy \<bsheedy@chromium.org>
Commit-Queue: Brandon Jones \<bajones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729896}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → WebVR
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 167 tests and 6 subtests

Status Summary

Firefox

OK : 1[GitHub] 160[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 140
FAIL : 4[GitHub] 1116[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
ERROR : 7

Chrome

TIMEOUT: 1
ERROR : 1
NOTRUN : 3

Safari

OK : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/407be60f851f https://hg.mozilla.org/integration/autoland/rev/6d8a001cd9e2 [wpt PR 64331] - Mark Opaque XR framebuffers as incomplete on session end, a=testonly
Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: