[wpt-sync] Sync PR 64121 - script: Use create_a_potential_cors_request_with_claim in htmlmediaelement.rs
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64121 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64121
Details from upstream follow.
rogerkorantenng <rogerkorantenng@gmail.com> wrote:
script: Use create_a_potential_cors_request_with_claim in htmlmediaelement.rs
Use
ensure_blob_referenced_by_url_is_kept_aliveto get aUrlWithBlobClaimfor the media element's resource URL infetch_request, then pass it tocreate_a_potential_cors_request_with_claiminstead of the temporarycreate_a_potential_cors_request.Testing: Added
tests/wpt/tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/media-blob-url-revoked.window.js. It loads an<audio>from a blob URL and has three subtests: the URL is never revoked, it is revoked in a microtask after the fetch has started (both should load), and it is revoked beforesrcis set (should fireerrorwithMEDIA_ERR_SRC_NOT_SUPPORTED). All three pass with the fix. They also passed without it in 15 of 15 local runs, because the request reaches the net thread before the revoke does, so this test is regression coverage rather than proof of the fix../mach test-tidyis clean. Try run: https://github.com/rogerkorantenng/servo/actions/runs/39981862598Note: seeks and resumed downloads call
fetch_requestagain and take a new claim, so if the page revokes the URL after the first load, those refetches will still fail. Happy to handle that in a follow-up if wanted.Fixes: Part of #<!-- nolink -->48892
Reviewed in servo/servo#49206
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Comment 1•11 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116225
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 51 tests and 1 subtests
Status Summary
Firefox
OK : 1[GitHub] 45[Gecko-android-em-14-x86_64-debug-geckoview] 50[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug] 51[Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
PASS: 2[GitHub] 35[Gecko-android-em-14-x86_64-debug-geckoview] 38[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 41[Gecko-windows11-32-25h2-opt] 42[Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-opt] 44[Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug]
FAIL: 1[GitHub] 15[Gecko-android-em-14-x86_64-debug-geckoview] 16[Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug] 18[Gecko-windows11-32-25h2-debug] 19[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
PASS: 2
FAIL: 1
Safari
OK : 1
PASS: 2
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/load-events-networkState.html [wpt.fyi]:
OK[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/load-removes-queued-error-event.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview]- inserting another source before the candidate:
FAIL
- inserting another source before the candidate:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-32-25h2-debug,Gecko-windows11-64-25h2-debug]- moving the candidate source:
FAIL
- moving the candidate source:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-currentSrc.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/media-blob-url-revoked.window.html [wpt.fyi]
- media loads from a blob: URL revoked after the fetch started:
FAIL(Chrome:FAIL, Safari:FAIL)
- media loads from a blob: URL revoked after the fetch started:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-addEventListener.html [wpt.fyi]
- removing the candidate source, addEventListener:
FAIL
- removing the candidate source, addEventListener:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-onerror.html [wpt.fyi]
- removing the candidate source, onerror:
FAIL
- removing the candidate source, onerror:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-windows11-32-25h2-opt] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html [wpt.fyi]
- invoking resource selection with new Audio(src):
FAIL
- invoking resource selection with new Audio(src):
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event.html [wpt.fyi]
- await a stable state and sync event handlers:
FAIL[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug]
- await a stable state and sync event handlers:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-networkState.html [wpt.fyi]
- NOT invoking resource selection by inserting <source> when networkState is not NETWORK_EMPTY:
FAIL
- NOT invoking resource selection by inserting <source> when networkState is not NETWORK_EMPTY:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-load.html [wpt.fyi]
- invoking resource selection with load():
FAIL
- invoking resource selection with load():
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-same-parent.html [wpt.fyi]
- invoking resource selection by moving <source> within the same media element:
FAIL
- invoking resource selection by moving <source> within the same media element:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause.html [wpt.fyi]
- invoking resource selection with pause():
FAIL
- invoking resource selection with pause():
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-play.html [wpt.fyi]
- invoking resource selection with play():
FAIL
- invoking resource selection with play():
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-src.html [wpt.fyi]
- NOT invoking media load or resource selection when removing the src attribute:
FAIL
- NOT invoking media load or resource selection when removing the src attribute:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-not-in-document.html [wpt.fyi]
- invoking load by setting src on video not in a document:
FAIL
- invoking load by setting src on video not in a document:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src.html [wpt.fyi]
- invoking load by setting src:
FAIL[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug]
- invoking load by setting src:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source.html [wpt.fyi]
- pointer updates (adding source elements):
FAIL
- pointer updates (adding source elements):
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html [wpt.fyi]
- pointer updates (removing source elements):
FAIL
- pointer updates (removing source elements):
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-source.html [wpt.fyi]
- Changes to networkState when inserting and removing a <source>:
FAIL
- Changes to networkState when inserting and removing a <source>:
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-src.html [wpt.fyi]
- invoking resource selection by setting src; await stable state:
FAIL
- invoking resource selection by setting src; await stable state:
Tests Disabled in Gecko Infrastructure
- /html/semantics/embedded-content/media-elements/loading-the-media-resource/load-events-networkState.html [wpt.fyi]:
OK[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/load-removes-queued-error-event.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-32-25h2-debug,Gecko-windows11-64-25h2-debug] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-currentSrc.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview] - /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src.html [wpt.fyi]:
OK[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-windows11-32-25h2-opt]
Comment 4•5 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/38ede4d353ae
https://hg.mozilla.org/mozilla-central/rev/6237e3b36dda
Description
•