Closed Bug 2089332 Opened 17 days ago Closed 9 days ago

[wpt-sync] Sync PR 64388 - ContainerTiming WPT: add helpers to build the test content

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64388 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64388
Details from upstream follow.

Jose Dapena Paz <jdapena@igalia.com> wrote:

ContainerTiming WPT: add helpers to build the test content

Most tests created their container roots, images and text with the same
createElement(), setAttribute() and appendChild() sequence. Add
addElement(), addContainerRoot(), addSquare100Image() and addText() to
container-timing-helpers.js and use them, dropping the comments that
only described that sequence. Attributes are still set before the
element is inserted.

Change-Id: Id25e27c0d0cb53de7746aeed3179a1f6cfd40e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8629366
Commit-Queue: José Dapena Paz \<jdapena@igalia.com>
Reviewed-by: Scott Haseley \<shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1731265}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests and 1 subtests

Status Summary

Firefox

OK : 29[GitHub] 40[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 41
FAIL: 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 29[GitHub]

Chrome

OK : 29
PASS: 29

Safari

OK : 29
FAIL: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /container-timing/tentative/containertiming-and-ignore-on-img-itself.html [wpt.fyi]
    • Image with both containertiming and containertimingignore reports its own paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-and-ignore-on-text-itself.html [wpt.fyi]
    • Text element with both containertiming and containertimingignore reports its own paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-body-with-child-img.html [wpt.fyi]
    • Body with containertiming observed reports children image paints.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-html-elements-only.html [wpt.fyi]
    • Only an HTMLElement can be a container root or ignored subtree root: FAIL
  • /container-timing/tentative/containertiming-img-already-loaded.html [wpt.fyi]
    • An already-loaded image with containertiming still reports its paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-img-itself.html [wpt.fyi]
    • Element with containertiming attribute is observable and reports the image paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-largest-painted-element-own-area.html [wpt.fyi]
    • lastPaintedElement is the element with the largest area of its own, not the largest newly painted area.: FAIL (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-largest-painted-element.html [wpt.fyi]
    • lastPaintedElement reports the largest element painted.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-observe-after-paint-with-buffering.html [wpt.fyi]
    • Paint is reported when observation starts after image paint if buffering is enabled.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-observe-after-paint-without-buffering.html [wpt.fyi]
    • containertiming does not report paints before observing if buffering is disabled.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-observe-no-paint.html [wpt.fyi]
    • Container timing did not report paints when there was nothing to paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-text-itself.html [wpt.fyi]
    • Element with containertiming attribute is observable and reports the text paint.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-two-overlapping-imgs.html [wpt.fyi]
    • Overlapping images report to containertiming.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-with-child-ignore-and-child-img.html [wpt.fyi]
    • Paint of the image child of container timing with ignore in the middle is not reported.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-with-child-img.html [wpt.fyi]
    • Paint of the image child of container timing is reported.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-with-child-text.html [wpt.fyi]
    • Paint of the text child of container timing is reported.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/containertiming-with-ignore-and-child-img.html [wpt.fyi]
    • Paint of the image child of container timing with ignore is not blocked.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/iframe-isolation-cross-origin.sub.html [wpt.fyi]
    • Container Timing entries from a cross-origin iframe do not appear in the parent observer.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/iframe-isolation-same-origin.html [wpt.fyi]
    • Container Timing entries from a same-origin iframe do not appear in the parent observer.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/ignore-with-containertiming-and-child-img.html [wpt.fyi]
    • An image inside a containertiming, inside a containertimingignore is still reported.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/img-not-child-of-container-timing.html [wpt.fyi]
    • Containertiming observed without paintable contents and an image outside does not report observations.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-and-ignore-on-img.html [wpt.fyi]
    • Image with containertiming + containertimingignore inside outer containertiming reports under itself only.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-and-ignore-on-text.html [wpt.fyi]
    • Text element with containertiming + containertimingignore inside outer containertiming reports under itself only.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-child-img-with-ignore.html [wpt.fyi]
    • A parent containertiming root does not get paints from a nested containertiming root if an intermediate containertimingignore is set.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-child-img.html [wpt.fyi]
    • Paints in a nested containertiming root are also reported to the parent containertiming root.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-on-img-without-ignore.html [wpt.fyi]
    • Image with containertiming (no ignore) inside outer containertiming reports under itself and propagates to the outer root.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/nested-containertiming-with-ignore.html [wpt.fyi]
    • A parent containertiming root does not get paints from a nested containertiming root with containertimingignore.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/pseudo-background-image-before-in-container-timing.html [wpt.fyi]
    • Element with a pseudo image before as background inside a container timing that is observed.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/pseudo-with-image-content-in-container-timing.html [wpt.fyi]
    • Element with a pseudo image before as content inside a container timing that is observed.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
  • /container-timing/tentative/pseudo-with-text-content-in-container-timing.html [wpt.fyi]
    • Element with a pseudo before text inside a container timing that is observed.: FAIL [GitHub], PASS [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/40e08b496c16 https://hg.mozilla.org/integration/autoland/rev/07fe29d6a161 [wpt PR 64388] - ContainerTiming WPT: add helpers to build the test content, a=testonly
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.