Closed Bug 2089334 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64376 - script: Fix failing close watcher assertion in dialog element.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64376 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64376
Details from upstream follow.

Luke Warlow <lwarlow@igalia.com> wrote:

script: Fix failing close watcher assertion in dialog element.

Previously the code didn't handle the case where you set an open attribute on a dialog that already has an open attribute. This was because it matched AttributeSet even when the old value was Some.

Testing: New crash test added
Fixes: #<!-- nolink -->49428

Reviewed in servo/servo#49431

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 149 tests

Status Summary

Firefox

OK : 86
PASS: 1[GitHub] 18[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 454[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 499[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 9

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/dfdc6e7180d3 https://hg.mozilla.org/integration/autoland/rev/268214d958c9 [wpt PR 64376] - script: Fix failing close watcher assertion in dialog element., a=testonly
Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.