[wpt-sync] Sync PR 64376 - script: Fix failing close watcher assertion in dialog element.
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64376 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64376
Details from upstream follow.
Luke Warlow <lwarlow@igalia.com> wrote:
script: Fix failing close watcher assertion in dialog element.
Previously the code didn't handle the case where you set an open attribute on a dialog that already has an open attribute. This was because it matched AttributeSet even when the old value was Some.
Testing: New crash test added
Fixes: #<!-- nolink -->49428Reviewed in servo/servo#49431
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Comment 1•10 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116227
| Assignee | ||
Comment 2•9 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 149 tests
Status Summary
Firefox
OK : 86
PASS: 1[GitHub] 18[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 454[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 499[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 9
Chrome
PASS: 1
Safari
PASS: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.tentative.html [wpt.fyi]
- Removing the open attribute from an open modal dialog should run the closing algorithm.:
FAIL - Removing the open attribute from an open non-modal dialog should fire a close event.:
FAIL
- Removing the open attribute from an open modal dialog should run the closing algorithm.:
- /html/semantics/interactive-elements/the-dialog-element/dialog-focusability.html [wpt.fyi]
- The dialog element itself should not be keyboard focusable.:
FAIL
- The dialog element itself should not be keyboard focusable.:
- /html/semantics/interactive-elements/the-dialog-element/dialog-form-submission.html [wpt.fyi]
- returnValue doesn't update when there's no value attribute.:
FAIL
- returnValue doesn't update when there's no value attribute.:
- /html/semantics/interactive-elements/the-dialog-element/dialog-light-dismiss-touch.html [wpt.fyi]
- Dialog light dismiss should work with touch and not trigger a click event.:
FAIL
- Dialog light dismiss should work with touch and not trigger a click event.:
- /html/semantics/interactive-elements/the-dialog-element/dialog-overlay.html [wpt.fyi]
- dialog computed overlay initially 'none':
FAIL - Opening and closing a modal dialog changes computed overlay to 'auto' and back to 'none':
FAIL
- dialog computed overlay initially 'none':
- /html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-closedby.tentative.html [wpt.fyi]
- requestClose() should close the dialog even when computed closedby becomes none:
FAIL
- requestClose() should close the dialog even when computed closedby becomes none:
- /html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html [wpt.fyi]
- when opening multiple dialogs, the most recently opened is rendered on top:
FAIL
- when opening multiple dialogs, the most recently opened is rendered on top:
Comment 4•4 days ago
|
||
| bugherder | ||
Description
•