[wpt-sync] Sync PR 64320 - script: No longer rely on the incumbent global when getting JSON attributes
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64320 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64320
Details from upstream follow.
Martin Robinson <mrobinson@igalia.com> wrote:
script: No longer rely on the incumbent global when getting JSON attributes
The included test case panicked because it triggered an unhandled
promise rejection. The stringifier would run as part of that code path
without an incumbent global. This change fixes that in two places:
- Stringification in this case is wrapped in
run_a_scriptso that the
settings stack is never empty. Stringification can run code, so this
is important.- Instead of getting the incumbent global for
CollectJSONAttributes,
the global is fetched from the object using the SpiderMonkey
API. This more closely matches Firefox.Testing: This change adds a WPT crash test.
Fixes: #<!-- nolink -->49308.Reviewed in servo/servo#49374
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Comment 1•11 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116236
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 15 tests
Status Summary
Firefox
OK : 13
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 176[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
PASS: 1
Safari
PASS: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-resolution-order.html [wpt.fyi]:
SKIP
Tests Disabled in Gecko Infrastructure
Comment 4•4 days ago
|
||
| bugherder | ||
Description
•