Closed Bug 2089340 Opened 13 days ago Closed 5 days ago

[wpt-sync] Sync PR 64379 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=313879

Categories

(Core :: Layout: Block and Inline, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64379
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=313879

WebKit export from bug: mercedes-<!---->benz.<!---->com:<!----> `<!---->arrow`<!----> next to text in menu drop-<!---->down is not on same baseline

<pre>
[block-in-inline] mercedes-benz.com: arrow next to text in menu drop-down is not on same baseline

When a block container has align-content: center, WebKit shifts all line
positions down so content appears centered vertically. This works by calling
shiftLinesByInBlockDirection, which moves line boxes and also updates the
actual render position of atomic inline boxes (like images or inline-blocks).

But it did not update block-level boxes that appear inside inline elements
(the "block-in-inline" case, like <span><div>X</div></span>). The display
box position in the inline content tree was shifted correctly, but the
RenderBox position -- which is what painting uses -- stayed at (0,0). So the
content appeared at the top instead of centered.

The fix adds block-level boxes to the same condition that already handles
atomic inline boxes, so their renderer position gets shifted too.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=313879">https://bugs.webkit.org/show_bug.cgi?id=313879</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/312514@main">https://commits.webkit.org/312514@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 57 tests and 24 subtests

Status Summary

Firefox

OK : 36
PASS: 1[GitHub] 289[Gecko-windows11-32-25h2-debug] 305[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 263[Gecko-windows11-32-25h2-debug] 268[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.