[wpt-sync] Sync PR 64381 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=313094
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64381 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64381
Details from upstream follow.
Alan Baradlay <zalan@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=313094
WebKit export from bug: Fix imported/<!---->w3c/<!---->web-<!---->platform-<!---->tests/<!---->css/<!---->css-<!---->writing-<!---->modes/<!---->margin-<!---->collapse-<!---->vrl-<!---->022.<!---->xht
<pre>
Fix css/css-writing-modes/margin-collapse-vrl-022.xhtWhen an absolutely positioned element has auto inset (top/left/right/bottom),
we compute a "static position" - where the element would have been if it
weren't absolutely positioned. This works fine in most cases, but breaks when the
parent has an orthogonal writing mode with a flipped axis (vs. the real containing block).For example, in vertical-rl the block axis runs right-to-left (flipped compared to
horizontal-tb's top-to-bottom). When an absolutely positioned child inside vertical-rl
uses static position, three things go wrong:
The static position is placed at the min edge (left), but it should be at the max
edge (right) because vertical-rl's block axis starts from the right.Margins are applied in the wrong direction - margin-right should push the element
away from the right edge, but it's treated as a before-margin on the wrong side.After computing the position, there's an adjustment that subtracts the element's
height (to convert from bottom-edge to top-edge positioning). This adjustment is
wrong when we've already corrected the static position to come from the right edge.The fix adds isOrthogonalWithParentFlippedAxis() which detects when the parent's axis
runs in the reverse direction. When it does: place the static position at the max edge,
swap the before/after margins, and skip the height adjustment.The same logic handles direction:rtl (inline-flipped) with orthogonal children.
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=313094">https://bugs.webkit.org/show_bug.cgi?id=313094</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/311868@main">https://commits.webkit.org/311868@main</a>
</pre>
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Updated•11 days ago
|
| Assignee | ||
Comment 1•11 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116275
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1248 tests and 3 subtests
Status Summary
Firefox
OK : 81
PASS: 1[GitHub] 13[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 390[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1516[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1519[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 1523[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 25[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 46[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 48[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 53[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
Chrome
PASS: 1
Safari
PASS: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-writing-modes/abs-pos-non-replaced-icb-vlr-021.xht [wpt.fyi]:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt],SKIP[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-writing-modes/abs-pos-non-replaced-icb-vrl-020.xht [wpt.fyi]:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt],SKIP[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-writing-modes/ch-units-vrl-007.html [wpt.fyi]:
FAIL - /css/css-writing-modes/ch-units-vrl-008.html [wpt.fyi]:
FAIL - /css/css-writing-modes/full-width-003.html [wpt.fyi]:
FAIL - /css/css-writing-modes/mongolian-orientation-001.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/css-writing-modes/mongolian-orientation-002.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/css-writing-modes/sizing-orthog-htb-in-vrl-001.xht [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-writing-modes/sizing-orthog-htb-in-vrl-004.xht [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-writing-modes/tcy-white-space-processing-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-all-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits2-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits2-002.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits3-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits3-002.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits4-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-value-digits4-002.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-shadow-sideways-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/vertical-alignment-vlr-023.xht [wpt.fyi]:
FAIL - /css/css-writing-modes/vertical-alignment-vlr-025.xht [wpt.fyi]:
FAIL - /css/css-writing-modes/vertical-alignment-vrl-022.xht [wpt.fyi]:
FAIL - /css/css-writing-modes/vertical-alignment-vrl-024.xht [wpt.fyi]:
FAIL - /css/css-writing-modes/wm-propagation-001.html [wpt.fyi]:
FAIL - /css/css-writing-modes/wm-propagation-body-042.html [wpt.fyi]:
FAIL - /css/css-writing-modes/wm-propagation-body-047.html [wpt.fyi]:
FAIL - /css/css-writing-modes/wm-propagation-body-049.html [wpt.fyi]:
FAIL - /css/css-writing-modes/wm-propagation-body-054.html [wpt.fyi]:
FAIL - /css/css-writing-modes/text-combine-upright-parsing-digits-001.html [wpt.fyi]
- Computed value for
text-combine-upright: digitsisdigits 2:FAIL - Computed value for
text-combine-upright: digits 2isdigits 2:FAIL - Computed value for
text-combine-upright: digits 3isdigits 3:FAIL - Computed value for
text-combine-upright: digits 4isdigits 4:FAIL - Computed value for
text-combine-upright: digits +2isdigits 2:FAIL - Computed value for
text-combine-upright: digits+3isdigits 3:FAIL - Computed value for
text-combine-upright: digits[TAB]4isdigits 4:FAIL - Computed value for
text-combine-upright: digits[LF]2isdigits 2:FAIL - Computed value for
text-combine-upright: digits [TAB]3isdigits 3:FAIL - Computed value for
text-combine-upright: digits[TAB][LF]4isdigits 4:FAIL
- Computed value for
- /css/css-writing-modes/text-combine-upright-parsing-digits-002.html [wpt.fyi]
- Computed value for
text-combine-upright: digits calc(1 + 1)isdigits 2:FAIL - Computed value for
text-combine-upright: digits calc(1 + 1 + 1)isdigits 3:FAIL - Computed value for
text-combine-upright: digits calc(2 + 2)isdigits 4:FAIL - Computed value for
text-combine-upright: digits calc(4 - 2)isdigits 2:FAIL - Computed value for
text-combine-upright: digits calc(6 - 3)isdigits 3:FAIL - Computed value for
text-combine-upright: digits calc(7 - 1 - 2)isdigits 4:FAIL - Computed value for
text-combine-upright: digits calc(2 * 1)isdigits 2:FAIL - Computed value for
text-combine-upright: digits calc(3 * 1)isdigits 3:FAIL - Computed value for
text-combine-upright: digits calc(2 * 2 * 1)isdigits 4:FAIL - Computed value for
text-combine-upright: digits calc(4 / 2)isdigits 2:FAIL - Computed value for
text-combine-upright: digits calc(6 / 2)isdigits 3:FAIL - Computed value for
text-combine-upright: digits calc(24 / 3 / 2)isdigits 4:FAIL
- Computed value for
- /css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative.html [wpt.fyi]
- horizontal-input block size should match height and inline size should match width:
FAIL - vertical-lr-input block size should match width and inline size should match height:
FAIL - vertical-rl-input block size should match width and inline size should match height:
FAIL
- horizontal-input block size should match height and inline size should match width:
- /css/css-writing-modes/forms/select-multiple-options-visual-order.html [wpt.fyi]
- select[multiple][style="writing-mode: horizontal-tb"] has visually correct option order:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - select[multiple][style="writing-mode: vertical-lr"] has visually correct option order:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - select[multiple][style="writing-mode: vertical-rl"] has visually correct option order:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - select[multiple][style="writing-mode: sideways-lr"] has visually correct option order:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - select[multiple][style="writing-mode: sideways-rl"] has visually correct option order:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt]
- select[multiple][style="writing-mode: horizontal-tb"] has visually correct option order:
Tests Disabled in Gecko Infrastructure
- /css/css-writing-modes/abs-pos-non-replaced-icb-vlr-021.xht [wpt.fyi]:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt],SKIP[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-writing-modes/abs-pos-non-replaced-icb-vrl-020.xht [wpt.fyi]:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt],SKIP[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt]
Comment 4•5 days ago
|
||
| bugherder | ||
Description
•