[wpt-sync] Sync PR 64306 - [flex] Remove item_indices vector in FlexLine
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64306 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64306
Details from upstream follow.
Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:
[flex] Remove item_indices vector in FlexLine
item_indices is not actually necessary in FlexLine, as at the point it
is created, all flex items are sequential. It is replaced with two
wtf_size_t's (item count and first index, respectively). Individual item
indices are then computed on-the-fly.This saves overall memory and reduces allocation overhead. Benchmarks
demonstrate this:Speedometer3: 0.1%
flexbox_with_list_item: 1%
flexbox-deeply-nested-with-ortho-flow: 3.4%
flexbox-nested-rows-and-columns-auto-overflow: 4%
Change-Id: Ib9394a672991e2971e54130f63d15e9ca624a1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8625835
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1728398}
| Assignee | ||
Updated•14 days ago
|
| Assignee | ||
Comment 1•10 days ago
|
||
PR 64306 applied with additional changes from upstream: 0645c5a40d9d26541256af5b4f7a1b8d3d13930c
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Comment 2•10 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116572
| Assignee | ||
Comment 3•9 days ago
|
||
CI Results
Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 38 tests and 5 subtests
Status Summary
Firefox
OK : 1[GitHub] 38[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 11
FAIL: 4[GitHub] 65[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
PASS: 4
Safari
OK : 1
FAIL: 4
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /shadow-dom/focus-navigation/reading-flow/carousel-grid-order.html [wpt.fyi]
- Grid items in carousel should follow grid-order reading flow:
FAIL
- Grid items in carousel should follow grid-order reading flow:
- /shadow-dom/focus-navigation/reading-flow/flex-flow.html [wpt.fyi]
- Flex items in flexbox should follow flex-flow reading flow:
FAIL(Chrome:PASS, Safari:FAIL) - Flex items in rtl flexbox should follow flex-flow reading flow:
FAIL(Chrome:PASS, Safari:FAIL) - Flex items in vertical-lr flexbox should follow flex-flow reading flow:
FAIL(Chrome:PASS, Safari:FAIL) - Flex-flow follows order-modified items with row-reverse and wrap-reverse:
FAIL(Chrome:PASS, Safari:FAIL)
- Flex items in flexbox should follow flex-flow reading flow:
- /shadow-dom/focus-navigation/reading-flow/flex-visual-fragmentation.html [wpt.fyi]
- CSS order is honored across fragments: flex-visual reading order follows visual placement, not source order:
FAIL
- CSS order is honored across fragments: flex-visual reading order follows visual placement, not source order:
- /shadow-dom/focus-navigation/reading-flow/flex-visual-order.html [wpt.fyi]
- Flex items in row-reverse flexbox should follow flex-visual reading flow:
FAIL - Flex items in row-reverse rtl flexbox should follow flex-visual reading flow:
FAIL - Flex items in row-reverse and vertical-lr flexbox should follow flex-visual reading flow:
FAIL
- Flex items in row-reverse flexbox should follow flex-visual reading flow:
- /shadow-dom/focus-navigation/reading-flow/flex-visual-wrapped-fragmentation.html [wpt.fyi]
- CSS Display: reading-flow: flex-visual finishes reading down each column, across fragments, before moving on to the next column :
FAIL
- CSS Display: reading-flow: flex-visual finishes reading down each column, across fragments, before moving on to the next column :
- /shadow-dom/focus-navigation/reading-flow/grid-auto-flow-reading-order.html [wpt.fyi]
- Grid items should follow grid-rows reading flow, but let reading-order can move item's focus order to the top.:
FAIL - Grid items should follow reading flow, mix of reading-order and order values.:
FAIL
- Grid items should follow grid-rows reading flow, but let reading-order can move item's focus order to the top.:
- /shadow-dom/focus-navigation/reading-flow/grid-columns-fragmentation.html [wpt.fyi]
- grid-columns follows complete grid columns across three multicol fragments:
FAIL
- grid-columns follows complete grid columns across three multicol fragments:
- /shadow-dom/focus-navigation/reading-flow/grid-columns.html [wpt.fyi]
- Grid items in grid template columns should follow grid-columns reading flow:
FAIL
- Grid items in grid template columns should follow grid-columns reading flow:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-001.html [wpt.fyi]
source-ordergroups byreading-orderand breaks ties bysource-order:FAIL
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-003.html [wpt.fyi]
grid-columnsfollows CSS order right-to-left within columns invertical-rl:FAIL
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-004.html [wpt.fyi]
- CSS Grid Lanes: reading-flow reads down each stacking axis with auto-placement:
FAIL
- CSS Grid Lanes: reading-flow reads down each stacking axis with auto-placement:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-006.html [wpt.fyi]
- Grid-order uses CSS order and source order for ties:
FAIL
- Grid-order uses CSS order and source order for ties:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-007.html [wpt.fyi]
- Grid-columns reads left-to-right columns with track-reverse placement:
FAIL - Grid-columns reads top-to-bottom within columns with fill-reverse placement:
FAIL
- Grid-columns reads left-to-right columns with track-reverse placement:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-008.html [wpt.fyi]
- Grid-columns reads spanning items once in visual column order:
FAIL - Grid-columns follows visual column order after dense backfill:
FAIL
- Grid-columns reads spanning items once in visual column order:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-010.html [wpt.fyi]
- Grid-columns reads fill-reverse columns from top-to-bottom:
FAIL
- Grid-columns reads fill-reverse columns from top-to-bottom:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-011.html [wpt.fyi]
- Grid-columns reads each complete column across fragments:
FAIL - Fill-reverse reads each complete column in reversed order across fragments:
FAIL
- Grid-columns reads each complete column across fragments:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-column-reading-flow-013.html [wpt.fyi]
- CSS Grid Lanes: stacking axis reading flow with densely-packed items:
FAIL
- CSS Grid Lanes: stacking axis reading flow with densely-packed items:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-row-reading-flow-001.html [wpt.fyi]
- Grid-rows reads top-to-bottom rows with track-reverse placement:
FAIL - Grid-rows reads left-to-right within rows with fill-reverse placement:
FAIL
- Grid-rows reads top-to-bottom rows with track-reverse placement:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-row-reading-flow-002.html [wpt.fyi]
- Grid-rows reads spanning items once in visual row order:
FAIL - Grid-rows follows visual row order after dense backfill:
FAIL
- Grid-rows reads spanning items once in visual row order:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-row-reading-flow-003.html [wpt.fyi]
- Grid-rows reads each row completely before the next:
FAIL
- Grid-rows reads each row completely before the next:
- /shadow-dom/focus-navigation/reading-flow/grid-lanes-row-reading-flow-004.html [wpt.fyi]
- Grid-rows reverses nested dense items within each row, not the rows:
FAIL
- Grid-rows reverses nested dense items within each row, not the rows:
- /shadow-dom/focus-navigation/reading-flow/grid-order-across-scopes.html [wpt.fyi]
- Grid items in shadow host that is a display contents grid item:
FAIL
- Grid items in shadow host that is a display contents grid item:
- /shadow-dom/focus-navigation/reading-flow/grid-order-on-shadow-host.html [wpt.fyi]
- Grid items in shadow host with delegatesFocus:
FAIL - Grid items in shadow host without delegatesFocus:
FAIL
- Grid items in shadow host with delegatesFocus:
- /shadow-dom/focus-navigation/reading-flow/grid-order-pseudo-elements.html [wpt.fyi]
- Grid pseudo items are not focusable:
FAIL
- Grid pseudo items are not focusable:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-display-contents.html [wpt.fyi]
- Items in display contents are sorted in same grid container and are placed in the position where their first child resides.:
FAIL - Items in display contents are sorted in same grid container and are placed in the position where their first child resides. The display contents have tabindex and should be focusable.:
FAIL - Grid items are in nested display contents containers.:
FAIL
- Items in display contents are sorted in same grid container and are placed in the position where their first child resides.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-iframe.html [wpt.fyi]
- Grid items are iframes.:
FAIL
- Grid items are iframes.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-nested-grids.html [wpt.fyi]
- Grid items are not grid containers.:
FAIL - Grid items are grid containers.:
FAIL - Only has grid containers.:
FAIL
- Grid items are not grid containers.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-popover.html [wpt.fyi]
- Popover is reading-flow item.:
FAIL - Popover is reading-flow item and reading-flow container.:
FAIL
- Popover is reading-flow item.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-position-absolute.html [wpt.fyi]
- Items in position:absolute container are visited at the end of the focus sequence. reading-order can override DOM order.:
FAIL - Items that have position:absolute are visited at the end of the focus sequence, in DOM order.:
FAIL
- Items in position:absolute container are visited at the end of the focus sequence. reading-order can override DOM order.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-position-fixed.html [wpt.fyi]
- Items in position:fixed container are visited at the end of the focus sequence. reading-order can override DOM order.:
FAIL - Items that have position:fixed are visited at the end of the focus sequence, in DOM order.:
FAIL
- Items in position:fixed container are visited at the end of the focus sequence. reading-order can override DOM order.:
- /shadow-dom/focus-navigation/reading-flow/grid-order-with-slots.html [wpt.fyi]
- Slot assigned element is a grid with reading-flow.:
FAIL - Slot is a grid with reading-flow.:
FAIL - Slot is inside a grid container with reading-flow.:
FAIL - Slot is a grid with reading-flow inside a grid container with reading-flow.:
FAIL - Slot is not inside a shadow host.:
FAIL - Slot is a display contents inside a grid container.:
FAIL - Slot is a display block inside a grid container.:
FAIL
- Slot assigned element is a grid with reading-flow.:
- /shadow-dom/focus-navigation/reading-flow/grid-order.html [wpt.fyi]
- Grid items with
orderproperty:FAIL - Grid items with
orderproperty and tabindex. Positive tabindex doesn't reorder reading flow item, but can affect its descendants.:FAIL - Items in display block are not in parent grid container.:
FAIL
- Grid items with
- /shadow-dom/focus-navigation/reading-flow/grid-rows.html [wpt.fyi]
- Grid items in grid template columns should follow grid-rows reading flow:
FAIL
- Grid items in grid template columns should follow grid-rows reading flow:
- /shadow-dom/focus-navigation/reading-flow/source-order-valid.html [wpt.fyi]
- Block elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
FAIL - Block inline elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
FAIL - Flex elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
FAIL - Grid elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
FAIL - Flow root elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
FAIL
- Block elements. Focus should be in DOM tabindexed-order, but reading-order takes effect.:
Comment 5•5 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8bf9f8e2ba12
https://hg.mozilla.org/mozilla-central/rev/85ab8c7c1673
Description
•