Closed Bug 2089348 Opened 14 days ago Closed 5 days ago

[wpt-sync] Sync PR 64306 - [flex] Remove item_indices vector in FlexLine

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64306 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64306
Details from upstream follow.

Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:

[flex] Remove item_indices vector in FlexLine

item_indices is not actually necessary in FlexLine, as at the point it
is created, all flex items are sequential. It is replaced with two
wtf_size_t's (item count and first index, respectively). Individual item
indices are then computed on-the-fly.

This saves overall memory and reduces allocation overhead. Benchmarks
demonstrate this:

Speedometer3: 0.1%

flexbox_with_list_item: 1%

flexbox-deeply-nested-with-ortho-flow: 3.4%

flexbox-nested-rows-and-columns-auto-overflow: 4%

Change-Id: Ib9394a672991e2971e54130f63d15e9ca624a1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8625835
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1728398}

Whiteboard: [wptsync downstream] → [wptsync downstream error]

PR 64306 applied with additional changes from upstream: 0645c5a40d9d26541256af5b4f7a1b8d3d13930c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 38 tests and 5 subtests

Status Summary

Firefox

OK : 1[GitHub] 38[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 11
FAIL: 4[GitHub] 65[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 4

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.