[wpt-sync] Sync PR 64307 - [gap-decorations] Fix flex rule with space-between
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64307 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64307
Details from upstream follow.
Javier Contreras Tenorio <javiercon@microsoft.com> wrote:
[gap-decorations] Fix flex rule with space-between
Flex gap decorations place each column rule at the midpoint of the
effective gap, which is thegapplus the space thatjustify-content
inserts between items.For
space-aroundandspace-evenly, these values are equal, so the
rule was correct. However, I found a bug forspace-betweenwhere with
exactly two items in a line, there is no space after the last item, so
the effective gap was only thegapvalue. As a result, the rule was
painted next to the second item instead of at the center of the gap.This CL records the effective gap size from the space after the first
item, which is the space between the first two items.This CL adds flex-gap-decorations-070 to cover the three distribution
values.Change-Id: Ia6fa3aeaf6e39f5ffb1f7a71aa8d5f2b8c2759ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8670887
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1729153}
| Assignee | ||
Updated•17 days ago
|
| Assignee | ||
Updated•15 days ago
|
| Assignee | ||
Updated•15 days ago
|
| Assignee | ||
Comment 1•15 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116347
| Assignee | ||
Comment 2•14 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 119 tests
Status Summary
Firefox
PASS: 3[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 7[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 112[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
PASS: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-gaps/flex/flex-gap-decorations-001.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-002.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-003.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-004.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-005.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-006.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-007.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-008.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-009.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-010.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-011.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-012.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-013.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-014.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-015.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-016.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-017.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-018.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-019.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-020.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-021.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-022.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-023.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-024.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-025.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-027.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-028.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-029.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-030.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-031.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-032.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-033.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-034.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-035.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-036.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-037.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-039.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-040.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-041.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-042.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-043.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-044.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-045.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-046.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-047.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-048.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-049.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-050.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-051.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-052.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-053.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-054.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-055.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-056.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-058.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-059.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-060.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-061.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-063.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-064.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-065.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-066.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-067.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-068.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-070.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/css-gaps/flex/flex-gap-decorations-auto-repeat-flex-direction-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-direction-inset.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-integer-repeat-flex-direction-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-column-reverse-uneven-lines.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-direction.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-flex-direction-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-reverse-direction-interaction.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-width-flex-direction-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-wrap-reverse-uneven-lines.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-wrap-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-multi-value-writing-mode.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/flex-gap-decorations-writing-mode.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-001.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-002.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-003.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-004.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-005.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-006.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-007.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-008.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-009.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-010.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-011.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-012.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-013.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-014.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-015.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-016.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-017.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-018.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-019.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-020.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-021.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-023.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-024.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-025.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-026.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-027.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-028.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-029.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-030.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-031.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-032.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-033.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-034.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-035.html [wpt.fyi]:
FAIL - /css/css-gaps/flex/webkit-box.tentative.html [wpt.fyi]:
FAIL
Comment 4•9 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/57f72d0257e5
https://hg.mozilla.org/mozilla-central/rev/31586192695e
Description
•