Closed Bug 2089353 Opened 17 days ago Closed 9 days ago

[wpt-sync] Sync PR 64307 - [gap-decorations] Fix flex rule with space-between

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64307 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64307
Details from upstream follow.

Javier Contreras Tenorio <javiercon@microsoft.com> wrote:

[gap-decorations] Fix flex rule with space-between

Flex gap decorations place each column rule at the midpoint of the
effective gap, which is the gap plus the space that justify-content
inserts between items.

For space-around and space-evenly, these values are equal, so the
rule was correct. However, I found a bug for space-between where with
exactly two items in a line, there is no space after the last item, so
the effective gap was only the gap value. As a result, the rule was
painted next to the second item instead of at the center of the gap.

This CL records the effective gap size from the space after the first
item, which is the space between the first two items.

This CL adds flex-gap-decorations-070 to cover the three distribution
values.

Change-Id: Ia6fa3aeaf6e39f5ffb1f7a71aa8d5f2b8c2759ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8670887
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1729153}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 119 tests

Status Summary

Firefox

PASS: 3[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 7[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 112[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.