Closed Bug 2089354 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64309 - [masonry] Update visibility to be computed before rule-break

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64309 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64309
Details from upstream follow.

Javier Contreras <javiercon@microsoft.com> wrote:

[masonry] Update visibility to be computed before rule-break

In line with recent edits to the css-gaps spec, we are updating the
rule-visibility states for grid lanes to be computed pre rule-break
rather than post rule-break. The change that introduced
rule-visibility for grid-lanes was under the impression that the
spec would change to apply them post rule-break, however after
discussion that turned out to not be the case.

With this CL, we now compute the visibility state for every lane (gap)
by checking whether each segment in the gap has a "empty" window
adjacent to it.

The methods were moved to GapGeometry now since it makes more sense for
the utils to be there rather than in the painter.

The overall complexity class of the gap decorations painter does not
change.

Some edits were needed to two WPTs that tested the wrong behavior
assumed by the previous CL.

https://drafts.csswg.org/css-gaps-1/#visibility

Change-Id: I3b14782613df4a8a79dcb504d4b31202fa1c2e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8654933
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729190}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 194 tests

Status Summary

Firefox

PASS: 9
FAIL: 3[GitHub] 185[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 3

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.