Closed Bug 2089355 Opened 14 days ago Closed 5 days ago

[wpt-sync] Sync PR 64317 - [sda] Make ViewTimelineOptions and subject mandatory

Categories

(Core :: DOM: Animation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64317 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64317
Details from upstream follow.

Kevin Ellis <kevers@google.com> wrote:

[sda] Make ViewTimelineOptions and subject mandatory

CSSWG issue with resolution:
https://github.com/w3c/csswg-drafts/issues/13959

A ViewTimeline is not useful without a subject, since the subject
member is readonly. You essentially have a timeline that is forever
inactive. The CSSWG resolved to make ViewTimelineOptions mandatory
in the constructor, and the subject mandatory within the options.

This path resolves the remaining interop failure for scroll-
animations.

Bug: 507395681
Change-Id: I7dcbcfb68f896f69d87f31a26c253cc0e3c0f83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8581323
Reviewed-by: David A \<awogbemila@chromium.org>
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729196}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 9

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /web-animations/interfaces/TimelineTrigger/constructor.html [wpt.fyi]
    • Empty ranges when no list is supplied.: FAIL (Chrome: PASS, Safari: FAIL)
    • Empty ranges when empty list is supplied.: FAIL (Chrome: PASS, Safari: FAIL)
    • Default values when an empty property bag is supplied.: FAIL (Chrome: PASS, Safari: FAIL)
    • All values supplied (scroll timeline).: FAIL (Chrome: PASS, Safari: FAIL)
    • All values supplied (view timeline).: FAIL (Chrome: PASS, Safari: FAIL)
    • Entry range supplied; active copied from entry: FAIL (Chrome: PASS, Safari: FAIL)
    • Active range supplied; entry copied from active: FAIL (Chrome: PASS, Safari: FAIL)
    • Multiple (empty) timelines not supported: FAIL (Chrome: PASS, Safari: FAIL)
    • Multiple timelines not supported: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9e4a967eaaef https://hg.mozilla.org/integration/autoland/rev/53701ddc8fd2 [wpt PR 64317] - [sda] Make ViewTimelineOptions and subject mandatory, a=testonly
Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.