Closed Bug 2089356 Opened 15 days ago Closed 7 days ago

[wpt-sync] Sync PR 64325 - [HiC] Fix CanvasTransform with CSS object-fit

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64325 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64325
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

[HiC] Fix CanvasTransform with CSS object-fit

When CSS object-fit is used the canvas bitmap may not fill the canvas
element's layout box or may be clipped or may be rescaled. Previously,
this was not accounted for in the CanvasTransform resulting in
incorrectly positioned elements for hit testing and selection.

Fix the issue by keeping the offset for the bitmap in the canvas child
paint state and then applying it to the canvas transform.

Fixed: 567607176
Change-Id: If19ce2b7dc79db040171a1a89ea0d48ccc28a9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8510719
Commit-Queue: Stefan Zager \<szager@chromium.org>
Auto-Submit: Stephen Chenney \<schenney@chromium.org>
Reviewed-by: Stefan Zager \<szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1729310}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 4 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 8[GitHub] 14[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 3
FAIL : 8[GitHub] 45[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1
ERROR : 1
NOTRUN : 2

Chrome

OK : 8
PASS : 8

Safari

OK : 8
FAIL : 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 4 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 8[GitHub] 14[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 3
FAIL : 8[GitHub] 45[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1
ERROR : 1
NOTRUN : 2

Chrome

OK : 8
PASS : 8

Safari

OK : 8
FAIL : 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.