[wpt-sync] Sync PR 64328 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328386
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64328 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64328
Details from upstream follow.
Jessica Cheung <jcheung23@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328386
WebKit export from bug: On dentaistudy.<!---->com,<!----> entry field does not return to initial position after dismissing keyboard
<pre>
On dentaistudy.com, entry field does not return to initial position after dismissing keyboardOn dentaistudy.com, which uses
interactive-widget=resizes-content, the
text input moves up when the virtual keyboard appears but does not move
back down after the keyboard is dismissed. This is a grid layout bug,
not an interactive-widget bug:resizes-contentjust makes it easy to
reproduce, because the keyboard shrinks the page's height: 100dvh grid
and dismissing it grows the grid back.The input sits below an auto row whose grid item has min-height: 0.
When the grid gets shorter, that row correctly shrinks to fit the
remaining space, and the item is stretched to the smaller row. When the
grid gets taller again, the row should grow back to the item's content
height, but it stays small, so the input stays where the keyboard moved
it.GridTrackSizingAlgorithmStrategy::logicalHeightForGridItem() measures an
item by calling layoutIfNeeded() and reading its logicalHeight(). If the
item isn't marked for layout, nothing is recomputed, so the row gets the
item's old stretched height. This can happen when the grid's intrinsic
logical height cache has no value for the item.clearGridItemOverridingSizesBeforeLayout() removes each item's
overriding size without marking the item for layout. Now, it flags items
that had a block-axis overriding size with
NeedsLayoutForIntrinsicLogicalHeight.When logicalHeightForGridItem() measures a flagged item that has no
cached value, it marks the item for layout, so its real content height
is used. The flag is then cleared, so each item is relaid out at most
once per grid layout.Add a layout test that exercises replicates this use case with the keyboard.
Add a WPT test that exercises this grid layout issue.WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328386">https://bugs.webkit.org/show_bug.cgi?id=328386</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324575@main">https://commits.webkit.org/324575@main</a>
</pre>
| Assignee | ||
Updated•15 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Comment 1•12 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116373
| Assignee | ||
Comment 2•11 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 105 tests
Status Summary
Firefox
OK : 1[GitHub] 59[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 841[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 882[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 44[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 45[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 1
PASS: 1
Safari
OK : 1
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-grid/layout-algorithm/flex-tracks-with-fractional-size.html [wpt.fyi]:
FAIL - /css/css-grid/layout-algorithm/automatic-minimum-size-clamped-to-fixed-max-track-sizing-function.html [wpt.fyi]
- An item taller than its track does not grow the track past its fixed maximum:
FAIL - An item taller than its track does not grow the track past its fixed maximum when the grid container height is definite:
FAIL - An item shorter than its track's fixed maximum still lets the track grow to that maximum:
FAIL - An item taller than its track grows a track whose maximum is intrinsic:
FAIL - A specified minimum size is not clamped to the track's fixed maximum:
FAIL - A scroll container taller than its track does not grow the track past its fixed maximum:
FAIL - An item spanning several tracks does not grow any of them past their fixed maximums:
FAIL - An item with margins does not grow its track past its fixed maximum:
FAIL - An item taller than its track does not grow the track past a definite percentage maximum:
FAIL - An item taller than its track does not grow the track past a definite calc() maximum:
FAIL
- An item taller than its track does not grow the track past its fixed maximum:
- /css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html [wpt.fyi]
- 'grid' with: grid-template-columns: 1fr 1fr 1fr; and grid-template-rows: 1fr 1fr 1fr;:
FAIL
- 'grid' with: grid-template-columns: 1fr 1fr 1fr; and grid-template-rows: 1fr 1fr 1fr;:
- /css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-003.html [wpt.fyi]
- min-content min item 'grid' with: grid-template-columns: 0.5fr auto; and grid-template-rows: 0.5fr auto;:
FAIL - 50px min item 'grid' with: grid-template-columns: 0.5fr auto; and grid-template-rows: 0.5fr auto;:
FAIL
- min-content min item 'grid' with: grid-template-columns: 0.5fr auto; and grid-template-rows: 0.5fr auto;:
- /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html [wpt.fyi]
- .grid 2:
FAIL - .grid 3:
FAIL
- .grid 2:
- /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html [wpt.fyi]
- .grid 2:
FAIL - .grid 3:
FAIL
- .grid 2:
- /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html [wpt.fyi]
- .grid 2:
FAIL - .grid 3:
FAIL
- .grid 2:
- /css/css-grid/layout-algorithm/grid-spanning-items-orthogonal-flows-001.html [wpt.fyi]
- .grid 1:
FAIL - .grid 3:
FAIL - .grid 4:
FAIL
- .grid 1:
- /css/css-grid/layout-algorithm/minmax-tracks-with-fixed-breadths.html [wpt.fyi]
- A track with an automatic minimum grows to its fixed maximum:
FAIL - A track with a min-content minimum grows to its fixed maximum:
FAIL - A track with a max-content minimum grows to its fixed maximum:
FAIL - A track with an automatic minimum grows to its percentage maximum:
FAIL - A track with a min-content minimum grows to its percentage maximum:
FAIL - A track with a max-content minimum grows to its percentage maximum:
FAIL - A track with an automatic minimum grows to its calculated maximum:
FAIL - A track with a min-content minimum grows to its calculated maximum:
FAIL - A track with a max-content minimum grows to its calculated maximum:
FAIL - A track with a min-content maximum keeps its fixed minimum:
FAIL - A track with a max-content maximum keeps its fixed minimum:
FAIL - A track with an automatic maximum keeps its fixed minimum:
FAIL - A track with a min-content maximum keeps its percentage minimum:
FAIL - A track with a max-content maximum keeps its percentage minimum:
FAIL - A track with an automatic maximum keeps its percentage minimum:
FAIL - A track with a min-content maximum keeps its calculated minimum:
FAIL - A track with a max-content maximum keeps its calculated minimum:
FAIL - A track with an automatic maximum keeps its calculated minimum:
FAIL - Every track with an automatic minimum grows to its fixed maximum:
FAIL - A track with an automatic minimum grows to its fixed maximum when the grid container height is indefinite:
FAIL - A track with an automatic maximum keeps its fixed minimum when the grid container height is indefinite:
FAIL - A track whose minimum and maximum are both fixed grows to its maximum:
FAIL
- A track with an automatic minimum grows to its fixed maximum:
Comment 4•6 days ago
|
||
| bugherder | ||
Description
•