Closed Bug 2089361 Opened 15 days ago Closed 6 days ago

[wpt-sync] Sync PR 64402 - [FragmentedOofInCb] Resume fragmented OOFs in table section.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64402 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64402
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[FragmentedOofInCb] Resume fragmented OOFs in table section.

If a table section is the containing block of out-of-flow positioned
descendants, out-of-flow break tokens may now found directly under the
section.

Update BlockChildIterator to skip child tracking for resumed OOFs. Child
tracking is only used by table section and table row layout, and
sections/rows cannot have direct OOF children.

The test coverage for this was non-existent, so add a test that would
have failed without this fix.

Bug: 40267498
Change-Id: I2d93dcb4c2391c2bfeb3aa8c52f7a8b841fc3948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8692448
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1731651}

Whiteboard: [wptsync downstream] → [wptsync downstream error]

PR 64402 applied with additional changes from upstream: 99d45d53e39441fb7fe6828cc46e7b9da02f0337

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

Try push failed to land: Lando job 116382 for the try push is FAILED:
Aborting, could not apply patch buffer for None.
hg error in cmd: hg import -s 95 --date 1794092869 0 --user moz-wptsync-bot <wptsync@mozilla.com> --logfile /tmp/tmp6m7f8c1bmsg /tmp/tmpfv9thghfdiff: applying /tmp/tmpfv9thghfdiff

abort: /tmp/tmpfv9thghfdiff: no diffs found

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.