Closed Bug 2089374 Opened 14 days ago Closed 5 days ago

[wpt-sync] Sync PR 64414 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=326836

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64414 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64414
Details from upstream follow.

Sam Weinig <sam@webkit.org> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=326836

WebKit export from bug: \<<!---->svg:<!---->image><!----> should cause referenced SVG images to treat their own root preserveAspectRatio as none

<pre>
<svg:image> should cause referenced SVG images to treat their own root preserveAspectRatio as none

SVG2 says:

"For ‘image’ elements embedding an SVG image, the ‘preserveAspectRatio’ attribute on the root element in the
referenced SVG image must be ignored, and instead treated as if it had a value of none."

 - <a href="https://w3c.github.io/svgwg/svg2-draft/embedded.html#ImageElement">https://w3c.github.io/svgwg/svg2-draft/embedded.html#ImageElement</a>

To implement this, we now pass a new flag IgnoreRootPreserveAspectRatio when painting <svg:image> elements
(both RenderSVGImage and LegacyRenderSVGImage) and implement the rest of the placement sizing via new helpers.

In the follow on changes we can add support for object-fit and object-position in this shared placement code.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=326836">https://bugs.webkit.org/show_bug.cgi?id=326836</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/323568@main">https://commits.webkit.org/323568@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 551 tests

Status Summary

Firefox

OK : 44
PASS: 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3519[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3964[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 89[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 142[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Safari

PASS: 5
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.